Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple favicons #1

Open
Princesseuh opened this issue Oct 9, 2018 · 0 comments · May be fixed by #3
Open

Add support for multiple favicons #1

Princesseuh opened this issue Oct 9, 2018 · 0 comments · May be fixed by #3
Assignees
@Princesseuh

Comments

@Princesseuh
Copy link
Owner

Princesseuh commented Oct 9, 2018 •
edited
Loading

Currently the favicon is implemented as a single line with a fileExists check. This is fairly rigid and prevent users from adding multiple favicons (be it for compatibility sake or just multiple sizes)

Ideally the theme should at least support declaring favicons for all the common sizes (16, 32, 96px) in PNG dynamically removing/adding the proper head tag when needed.

Optimally we should also support .ico, Apple Touch and Windows Metro icons.

Good luck!
@Princesseuh Princesseuh linked a pull request Oct 31, 2018 that will close this issue
Open
2 tasks
@Princesseuh Princesseuh self-assigned this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Princesseuh Princesseuh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multiple favicons support Princesseuh/hugo-royal-theme
1 participant
@Princesseuh