Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results not highlighting all matches in description #1035

Closed
richmanrachel opened this issue Aug 24, 2022 · 1 comment
Closed

Search results not highlighting all matches in description #1035

richmanrachel opened this issue Aug 24, 2022 · 1 comment
Assignees
Labels
🐛 bug Something isn't working

Comments

@richmanrachel
Copy link

Describe the bug
As discussed in #814, the search algorithm is correctly pulling some close matches but not displaying them with highlights on the search result page.

To reproduce
Steps to reproduce the behavior:

  1. Search for: مولاى
  2. See that first result does not highlight the term (PGPID 35813).
  3. Click into 35813, see that description includes مولاي

Expected behavior
The term مولاي and surrounding Arabic words show up in search results

Screenshots
Search results:
image

Doc. detail page:
image

@rlskoeser rlskoeser added the 🐛 bug Something isn't working label Nov 22, 2022
@rlskoeser
Copy link
Contributor

Resolved by the changes for #1211 — there's now only one description field instead of two, so it's not possible to get a match that isn't highlighted as it was before. Did some testing and confirmed in QA.

@rlskoeser rlskoeser changed the title Search results not highlighting all matches Search results not highlighting all matches in description Nov 22, 2022
@rlskoeser rlskoeser self-assigned this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants