Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine (and possibly mitigate) impact of indexing on annotation editing #1084

Closed
blms opened this issue Sep 13, 2022 · 2 comments
Closed
Assignees
Labels
🛠️ chore One-off task or update

Comments

@blms
Copy link
Contributor

blms commented Sep 13, 2022

It occurred to me from watching the logging that there may be some slowness with updating annotations due to the fact that we're reindexing documents on every change. We may want to add some time stamp / duration logging to our annotation signal handler to get a better sense of how much of an impact this is. It would be nice if we could delay the indexing or wait until a batch of edits is complete, but I'm not sure how we could do that without a queue manager or something like that.

Originally posted by @rlskoeser in Princeton-CDH/annotorious-tahqiq#15 (comment)

@rlskoeser
Copy link
Contributor

@blms resolved by #1329 ?

@blms
Copy link
Contributor Author

blms commented Mar 8, 2023

@rlskoeser Looks like it: tested on QA and indexing/annotation saving is almost instant, even when reordering annotations on a document with many annotations. Closing!

@blms blms closed this as completed Mar 8, 2023
@rlskoeser rlskoeser self-assigned this Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

2 participants