Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arabic type styles for the site so that users can read and navigate the content in Arabic #1135

Closed
gissoo opened this issue Sep 29, 2022 · 3 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Sep 29, 2022

@blms we are using Amiri for transcription content, and Hassan for all other site content. WOFF Hassan files are here and TTF Amiri files are here – I couldn't get the WOFF format of Amiri.

Here in Figma you can find all the Arabic type styles

let me know if you have any questions.

@gissoo gissoo added 💬 awaiting review Ready for comments and questions 🗺️ design Tracks design work in an external app labels Sep 29, 2022
@gissoo gissoo self-assigned this Sep 29, 2022
@blms
Copy link
Contributor

blms commented Sep 29, 2022

Thanks, @gissoo! This looks very clear. (Is this meant to be my implementation issue, or just for me to review the design?)

@rlskoeser is it OK that the second font is only available in TTF?

If so—we will still need to move Amiri into the "woff files only" folder so that devs know where to download it for their local install. As such, we'll probably need to rename that folder to "font files only" or something along those lines! (And I'll update the dev notes accordingly.)

@rlskoeser
Copy link
Contributor

@blms can we / should we generate WOFF from the TTF ourselves? or is TTF fine for web font? agree everything should be in the same folder either way

@gissoo
Copy link
Contributor Author

gissoo commented Sep 30, 2022

Just to document some decisions here due to implementation complexities:
for cases where Arabic and Latin are mixed, such as the descriptions, and metadata fields, Ben and I agreed on going with a larger line height (30), and a fixed size gap between the Latin and Arabic of 125% (in most cases Arabic being 25px and Latin 20px)

@gissoo gissoo closed this as completed Sep 30, 2022
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants