Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental transcription export sync needs to be single threaded (can't run in signal handler) #1140

Closed
4 tasks done
rlskoeser opened this issue Sep 29, 2022 · 1 comment
Closed
4 tasks done
Assignees
Labels
🛠️ chore One-off task or update

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Sep 29, 2022

this is a new approach to functionality you already tested on #1096

Please test again the same way:

  • edit an existing transcription and make a few text changes
  • edit an existing transcription that has content on more than one image; remove blocks of content so there is only content on image (one of the annotation list files should be removed;
  • add a new transcription
  • remove an existing transcription entirely — the corresponding exports should be removed from github

updates are being pushed to this test branch: https://github.com/Princeton-CDH/test-pgp-annotations/tree/test-tei-migration2

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Sep 29, 2022
@rlskoeser rlskoeser added this to the CDH/PGP end of grant year 2 milestone Sep 29, 2022
@rlskoeser rlskoeser self-assigned this Sep 29, 2022
@rlskoeser rlskoeser changed the title transcription export signal handler needs to be git lockfile aware regular transcription export sync needs to be single threaded (can't run in signal handler) Oct 4, 2022
@rlskoeser rlskoeser changed the title regular transcription export sync needs to be single threaded (can't run in signal handler) incremental transcription export sync needs to be single threaded (can't run in signal handler) Oct 4, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label Oct 5, 2022
@rlskoeser
Copy link
Contributor Author

Thanks @kseniaryzhova for testing all the cases listed in the issue notes!

Ben and I just tested making simultaneous edits on different documents, and confirmed that the export script created two different commits, with each of us co-author on the change for the record we modified.

@rlskoeser rlskoeser removed the 🗜️ awaiting testing Implemented and ready to be tested label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update
Projects
None yet
Development

No branches or pull requests

1 participant