-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External links page design revisions #246
Comments
please review what I have proposed based on our conversations yesterday, here
|
@thatbudakguy and @gissoo - am I supposed to be following this too, or is this just for dev now? |
@richmanrachel not sure! I defer to @gissoo. re: the new changes — I really like the idea of including fragment thumbnails here! we should probably try it out to see how it looks, but I think it's a fun way to make this page more interesting and meaningful. We would probably need a UI for fragments that have multiple images (this might be a good place to try out those transitions that @rlskoeser shared) and also something to show for fragments with no image (an icon or placeholder). I also would be OK with renaming this page (maybe something like "Collection Records" or "Holdings" or something) and then we can list all the fragments here, not just ones with links. If we did that, I think it still belongs in the document navigation/tabs. Would really like to hear the team's opinion on this though. everything else looks good. I don't think it's explicitly stated, but to me it makes sense to group these links by library, followed by collection, with each group being sorted alphabetically. |
last thought: I think it might be nice to include an icon that conveys "external link" as part of the fragment links. the one I usually see is the little box with an arrow going out of it. |
in working to implement a first-pass version of the document external links page, I had some questions about how to translate the design into a template. most of these questions are assuming that what we're calling "external links" are just links to view fragments — if that assumption is wrong, then some of these questions might not make sense!
in figma, i was looking at the "external links" frame on the "doc detail view" page (although the one on "document title" is the same, as far as I can tell).
The text was updated successfully, but these errors were encountered: