Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External links page design revisions #246

Closed
thatbudakguy opened this issue Jun 17, 2021 · 4 comments
Closed

External links page design revisions #246

thatbudakguy opened this issue Jun 17, 2021 · 4 comments
Assignees
Labels
🗺️ design Tracks design work in an external app 🚫 wontfix This will not be worked on

Comments

@thatbudakguy
Copy link
Contributor

in working to implement a first-pass version of the document external links page, I had some questions about how to translate the design into a template. most of these questions are assuming that what we're calling "external links" are just links to view fragments — if that assumption is wrong, then some of these questions might not make sense!

in figma, i was looking at the "external links" frame on the "doc detail view" page (although the one on "document title" is the same, as far as I can tell).

  • the external links seem to be grouped. are they grouped by library or by collection? some collections in our current data don’t have a library.
  • the design includes some filler text underneath the name of the collection. what would go here?
  • the design has an ordered (numbered) list of collections or libraries. what determines this order?
  • the first item in the list in the design doesn’t have a “Link to source”. does this mean we should list fragments on this page even if they don’t have a link?
  • the design has an “editor” at the top and some other information. where does this come from? what is it intended to do?
@thatbudakguy thatbudakguy added 🛠️ chore One-off task or update 🗺️ design Tracks design work in an external app labels Jun 17, 2021
@gissoo
Copy link
Contributor

gissoo commented Jun 25, 2021

@rlskoeser @thatbudakguy

please review what I have proposed based on our conversations yesterday, here

  • I have removed the editor field from here as well.

  • I think it makes sense to sort these based on the one with the most number of fragments. I will double check with Marina.

  • You may see the collection info is in italics in the other version, I think it visually looks better, but I'm not sure if it causes any issues or confusions conceptually / content-wise.

@gissoo gissoo removed the 🛠️ chore One-off task or update label Jun 25, 2021
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Jun 25, 2021
@richmanrachel
Copy link

@thatbudakguy and @gissoo - am I supposed to be following this too, or is this just for dev now?

@thatbudakguy
Copy link
Contributor Author

thatbudakguy commented Jun 30, 2021

@richmanrachel not sure! I defer to @gissoo.

re: the new changes — I really like the idea of including fragment thumbnails here! we should probably try it out to see how it looks, but I think it's a fun way to make this page more interesting and meaningful. We would probably need a UI for fragments that have multiple images (this might be a good place to try out those transitions that @rlskoeser shared) and also something to show for fragments with no image (an icon or placeholder).

I also would be OK with renaming this page (maybe something like "Collection Records" or "Holdings" or something) and then we can list all the fragments here, not just ones with links. If we did that, I think it still belongs in the document navigation/tabs. Would really like to hear the team's opinion on this though.

everything else looks good. I don't think it's explicitly stated, but to me it makes sense to group these links by library, followed by collection, with each group being sorted alphabetically.

@thatbudakguy
Copy link
Contributor Author

last thought: I think it might be nice to include an icon that conveys "external link" as part of the fragment links. the one I usually see is the little box with an arrow going out of it.

@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Dec 17, 2021
@gissoo gissoo closed this as completed Apr 4, 2022
@rlskoeser rlskoeser added the 🚫 wontfix This will not be worked on label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app 🚫 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants