Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the header styles so that H2 and H3, and H3 and body text would become easier to distinguish from each other #704

Closed
gissoo opened this issue Mar 8, 2022 · 3 comments
Assignees
Labels
🛠️ chore One-off task or update 🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Mar 8, 2022

No description provided.

@gissoo gissoo added 🗺️ design Tracks design work in an external app 🛠️ chore One-off task or update labels Mar 8, 2022
@gissoo gissoo self-assigned this Mar 8, 2022
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Mar 22, 2022
@gissoo
Copy link
Contributor Author

gissoo commented Mar 22, 2022

@richmanrachel @mrustow Please look at the two proposed revisions and compare them to the current styles which I have also included here. I have placed the header sizes next to each header. The changes will affect the size of the page title as well, which you see here as well.

Here is the link to the revisions in Figma

@mrustow
Copy link

mrustow commented Mar 23, 2022

I prefer Proposal 1.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 25, 2022

Thanks @mrustow! I've also adjusted the sizes on mobile based on proposal 1 and updated the typestyle sheet here, on Figma NOTE: This change does not affect the Error page headers.

Screen Shot 2022-03-25 at 12 43 26 PM

@gissoo gissoo closed this as completed Mar 25, 2022
@rlskoeser rlskoeser removed the 💬 awaiting review Ready for comments and questions label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update 🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants