-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design the "related documents" page (instead of the external links page) #746
Comments
@rlskoeser @mrustow @richmanrachel
|
@gissoo - I like the idea of using the format from the search page. Would it be possible to include the whole description, though? Since there will usually be only one to two other documents on the same fragment, this will not be too long. Users will still want to click to get to the other document detail page for transcription, etc., but having the full description here would be very helpful. |
Here's an example of a bifolio with four different documents (though currently only 2 PGPIDs) that you could use for your mockup: https://geniza.princeton.edu/en/documents/1562/ |
@richmanrachel I think that's possible, especially since we had discussed doing that on search results (through expanded/collapsed behavior)? I defer to Rebecca since I'm not sure how hard it is on the implementation side. One more thing: @richmanrachel @mrustow, during my conversation with Rebecca I gained a better understanding of the meaning of "related" in "related documents", I think the term "related" is confusing, and feel some inconsistencies from our previous conversations, might be worth to rethink the name. |
@gissoo - great! You're right that there's some ambiguity, but it's partly because we still have not made a decision about whether the Related Documents tab will be just be "other documents on this fragment" or whether it should also be a place to find/utilize the "uncertain join" feature from the admin site. I'll see if I can squeeze this into tomorrow's agenda |
Displaying the full description is technically possible and should not be very difficult. Discussing the scope and naming of the page at our meeting would be helpful! Can we discuss grouping then as well? (should fragments be grouped, if so how do we group and label the groups) |
@rlskoeser - I forgot that I had already put this convo down as a meeting agenda item, so we will definitely discuss! Could you say more about grouping fragments? What do you mean? |
@rlskoeser @richmanrachel Here are the designs for the related documents page on desktop and on mobile – I'm using the example that Rachel linked to earlier, so it would look like the mock ups if we go through with the changes. Marina and I agreed on the following changes:
Please let me know if you notice any issues, or would like me to try different documents. |
It seems a little weird to me to make the document title not bold and the PGP ID bold (I wondered if there is a different way to highlight the id), but I understand the rationale and @gissoo if you think this works then it's ok with me. Technically these adjustments should be pretty easy to make. Everything else looks good to me. I'm fine with determining the relationship headings later, just a reminder that we'll have to be able to identify related documents somehow by information or structure that's available in the database. |
@gissoo - I agree with @rlskoeser that while the rationale for bolding only the PGPID makes sense that it looks funny, and perhaps we could do something other than bold to make it clearer? Everything else looks good to me too! I think some of the headings might be: |
@gissoo I had couple of ideas for other ways to visually highlight the PGP IDs:
|
@rlskoeser We took a turn here for this issue – we won't highlight the PGP ID in any way here instead we have revised the formatting of PGP ID and input date so that: (please see designs here)
Note: these changes would also be applied on the search results page |
I'm fine with all these changes. Can update search at the same time as we implement this page. Someone needs to provide language for the sort options to match the "in pgp since" language, but it's easy for us to update once we have it. |
The text was updated successfully, but these errors were encountered: