Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I would like to see historic and converted dates in document search results so that I can easily scan date information when it is known. #780

Closed
5 tasks done
rlskoeser opened this issue Apr 20, 2022 · 5 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Apr 20, 2022

testing notes

  • document date should display in search results the same way it does on document details
  • documents without date should not have document date in search result

Here's a search to find all documents on the test site with any value indexed for document date https://test-geniza.cdh.princeton.edu/en/documents/?q=document_date%3A%5B*+TO+*%5D&sort=relevance
(you may have to toggle back and forth between admin and public to see how it's structured / how it's displaying)

The way I have it indexed right now you can also do some limited searching; e.g, here are all the documents where the date starts with "Jum": https://test-geniza.cdh.princeton.edu/en/documents/?q=document_date%3AJum*&sort=relevance

dev notes

  • update Document index data to include full display date
  • add the new field to the solr queryset so they will be aliased and returned
  • display the new field on the document search result when set
@rlskoeser rlskoeser self-assigned this May 13, 2022
@rlskoeser rlskoeser added the 🗜️ awaiting testing Implemented and ready to be tested label May 16, 2022
@richmanrachel richmanrachel removed the 🗜️ awaiting testing Implemented and ready to be tested label May 17, 2022
@richmanrachel
Copy link

@rlskoeser - Looks great! Going to review this and #847 with Marina now, but I think we'll be good!

@richmanrachel
Copy link

@rlskoeser - We love it!

The only question that came up (and you can tell us if this is too persnickety), is that Document Date, Input Date, and PGPID are all given the same weight in the document list view:
image

Whereas, in the doc. detail view, Document Date is rightfully more prominent:
image

@gissoo - would it be possible to make the list view more consistent with the detail view? Renaming "Input Date" to "In PGP since" and perhaps making the input date and PGPID fields dark gray (rather than black)? This will help users distinguish which information is directly about the document rather than the database.

@rlskoeser
Copy link
Contributor Author

I've wondered about the discrepancy between the input date as displayed on search and the revisions we made on the document details page!

I think that should probably be tracked as a separate issue, though.

@richmanrachel
Copy link

@rlskoeser - great. I'll make a separate issue

@rlskoeser
Copy link
Contributor Author

Closing based on testing feedback, since we've created another issue to track the discrepancies between search result and document detail display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants