Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a mobile user when I select a tag I want to see which leaves on the tree belong to that tag so that I can learn more about and explore the related content of other leaves. #100

Closed
gissoo opened this issue Mar 6, 2023 · 8 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Mar 6, 2023

No description provided.

@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Mar 6, 2023
@gissoo gissoo self-assigned this Mar 6, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Mar 6, 2023

@jhimpele @rlskoeser we discussed what the tags look like and how they work on desktop. Please review what they look like and work on mobile on Figma as well. – The logic is the same as desktop, the selected tag looks slightly different due to the narrow width on mobile (proposing to make the selected tag full width on mobile)

@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Mar 6, 2023
@jhimpele
Copy link
Contributor

jhimpele commented Mar 7, 2023

Do we still have a plan to reduce the glow area and line width?

@rlskoeser
Copy link
Contributor

@gissoo I like the way you've placed the tag directly over the info panel on mobile! The only thing bothering me is that it looks like the X to close the panel and the X to close the tag are close but not quite aligned — could they match?

I think the zoom level on mobile will be slightly different to allow selecting leaves, but I'm assuming that is out of scope here since we haven't decided yet how we're going to handle it.n

My only other question is that I don't think the project info panel shows on mobile after the leaf details are closed. I thought we decide it would be closed after interacting with leaves, and then brought back with the info button (since we need more space for the tree). Or does the intro panel on mobile only close when the user actively closes it? In which case, do we keep track of whether they've closed it or not, and only show it here if they haven't closed it?

@gissoo
Copy link
Contributor Author

gissoo commented Mar 7, 2023

Do we still have a plan to reduce the glow area and line width?

@jhimpele

  • we already revised the line width when you asked for desktop, is it looking too thick on mobile? We can make it thinner on mobile, how is this looking?
  • about the glow area, I can adjust that in the code, it's not efficient to play with that here, I think. I can make it more similar to what you see on desktop.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 7, 2023

@gissoo I like the way you've placed the tag directly over the info panel on mobile! The only thing bothering me is that it looks like the X to close the panel and the X to close the tag are close but not quite aligned — could they match?

  • I had to revise the auto-layout structure of the panel to make them match, so now there are more layers in the auto-layout than before, also because I didn't want to widen the x on the tag container. Now the "x" in all mobile panels have a right margin of 12px. I'll need to create a chore to do some clean up on Figma for the change.

I think the zoom level on mobile will be slightly different to allow selecting leaves, but I'm assuming that is out of scope here since we haven't decided yet how we're going to handle it.n

  • yes, that is out of scope here.

My only other question is that I don't think the project info panel shows on mobile after the leaf details are closed. I thought we decide it would be closed after interacting with leaves, and then brought back with the info button (since we need more space for the tree). Or does the intro panel on mobile only close when the user actively closes it? In which case, do we keep track of whether they've closed it or not, and only show it here if they haven't closed it?

@rlskoeser
Copy link
Contributor

Thanks @gissoo — this looks good to me.

@jhimpele
Copy link
Contributor

jhimpele commented Mar 8, 2023

All looks good to me. Though I'm not sure where you adjust the glow, I do think it could be reduced by up to 50% width/spread.

@gissoo
Copy link
Contributor Author

gissoo commented Mar 8, 2023

@jhimpele I'll make sure you see it when I propose the change :)
thank you, both!

@gissoo gissoo closed this as completed Mar 8, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants