-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a mobile user when I select a tag I want to see which leaves on the tree belong to that tag so that I can learn more about and explore the related content of other leaves. #100
Comments
@jhimpele @rlskoeser we discussed what the tags look like and how they work on desktop. Please review what they look like and work on mobile on Figma as well. – The logic is the same as desktop, the selected tag looks slightly different due to the narrow width on mobile (proposing to make the selected tag full width on mobile) |
Do we still have a plan to reduce the glow area and line width? |
@gissoo I like the way you've placed the tag directly over the info panel on mobile! The only thing bothering me is that it looks like the X to close the panel and the X to close the tag are close but not quite aligned — could they match? I think the zoom level on mobile will be slightly different to allow selecting leaves, but I'm assuming that is out of scope here since we haven't decided yet how we're going to handle it.n My only other question is that I don't think the project info panel shows on mobile after the leaf details are closed. I thought we decide it would be closed after interacting with leaves, and then brought back with the info button (since we need more space for the tree). Or does the intro panel on mobile only close when the user actively closes it? In which case, do we keep track of whether they've closed it or not, and only show it here if they haven't closed it? |
|
|
Thanks @gissoo — this looks good to me. |
All looks good to me. Though I'm not sure where you adjust the glow, I do think it could be reduced by up to 50% width/spread. |
@jhimpele I'll make sure you see it when I propose the change :) |
No description provided.
The text was updated successfully, but these errors were encountered: