Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want the url to change when I select a tag so that I can bookmark or share the timetree with a specific tag selected. #114

Closed
Tracked by #110
rlskoeser opened this issue Mar 21, 2023 · 2 comments
Assignees

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Mar 21, 2023

dev notes

Similar to how we update browser location with a hash for the selected leaf, we should add a parameter for the selected tag; should be able to use searchParams to parse and update params and generate a string to replace the location with.

Want similar behavior to leaf hash — detect if there is a selected tag when the page loads and activate that tag. URL should use slugs but active tag display should be name; may need to generate a dict of tags and tag names somewhere, possibly in Hugo template as json for consumption by timetree code.

@quadrismegistus quadrismegistus self-assigned this Mar 22, 2023
@quadrismegistus
Copy link
Contributor

We don't want to use [server]/tags/land-claims, but [server]?tag=land-claims ?

@rlskoeser
Copy link
Contributor Author

reviewed and tested as part of #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants