Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tagline to the header under the site title #146

Closed
gissoo opened this issue Apr 10, 2023 · 9 comments
Closed

add tagline to the header under the site title #146

gissoo opened this issue Apr 10, 2023 · 9 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 10, 2023

this is the new text: Interweaving histories of Lunaapahkiing, “the land of the Delaware Lenape” and the unceded lands of the Princeton University campus.

@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Apr 10, 2023
@gissoo gissoo self-assigned this Apr 10, 2023
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Apr 11, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Apr 11, 2023

@rlskoeser @jhimpele what do you think about the line added below the site title? - please look at both desktop and mobile.

  • @rlskoeser I have created an autolayout contianer and put everything in the header inside it, so all the new vertical spacing and old padding are documented in there.
  • the font is in italics, and is 18px on desktop and 16 on mobile.

@rlskoeser
Copy link
Contributor

@gissoo it looks really long... Are we proposing that this will always display? Can you show how it looks with the timetree on the homepage?

Could we put it on one line on desktop by any chance?

Could you try my idea of omitting it from the header on mobile and including it at the top of the intro?

@jhimpele
Copy link
Contributor

Both of @rlskoeser 's suggestions sound good. Unfortunately, I think the work "the" has to be added as the second word. I will think about some shorter versions....Suggestions are very welcome

@rlskoeser
Copy link
Contributor

@jhimpele let's put the tagline in the google doc where you have been drafting the homepage text so we can wordsmith it there and brainstorm other ways to phrase it.

@gissoo could you suggest a target length?

@gissoo
Copy link
Contributor Author

gissoo commented Apr 12, 2023

@rlskoeser @jhimpele sorry! I forgot about that direction for mobile! How is it now on mobile? This is how I would style ithere you can see it on the homepage on desktop too

Also, one of the first things I tried was to fit it on one line on desktop but we can't do that at this length, it's too long and hard too read on one line especially as a line that's not part of any body text.

The length I would suggest is max 95 characters

@rlskoeser
Copy link
Contributor

I like that option better on mobile!

Is it weird that we're repeating the project title in the intro? (IDK why I'm only noticing it now; maybe it bothers me because your version in Figma is using a different title.)

@gissoo
Copy link
Contributor Author

gissoo commented Apr 12, 2023

we should talk about that! do we want to eliminate the title from the intro panel? That would make sense to me, unless we want to use a different language that would serve a different purpose @jhimpele

@jhimpele
Copy link
Contributor

I've copied the current version on the HOME doc for editing. YES< we should remove the same line from the Intro panel if it repeats....

https://docs.google.com/document/d/1SzALkoCaS-6nGTrBIJBg7ypP9h4iPEChQc6Y5zm9q9g/edit

@gissoo
Copy link
Contributor Author

gissoo commented Apr 17, 2023

According to our conversations we have made the following decisions:

  • we are going to place the tagline inside the panel as shown here on mobile and here on desktop
  • we are keeping the header within the intro panel, and write welcome in the Lenape language per Keely's proposal.

@gissoo gissoo closed this as completed Apr 17, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants