Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose type sizes for each content type on desktop and mobile #15

Closed
gissoo opened this issue Nov 28, 2022 · 5 comments
Closed

Propose type sizes for each content type on desktop and mobile #15

gissoo opened this issue Nov 28, 2022 · 5 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Nov 28, 2022

not in scope: the site title / display font

@rlskoeser rlskoeser added the 🗺️ design Tracks design work in an external app label Nov 28, 2022
@gissoo gissoo self-assigned this Nov 28, 2022
@gissoo gissoo changed the title Group the two typefaces and sizes for each content type on desktop Propose type sizes for each content type on desktop Jan 4, 2023
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Jan 12, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Jan 12, 2023

@rlskoeser @jhimpele

  • please take a look at the type sizes I've proposed for desktop and mobile here on Figma and let me know what you think
  • You can look at them on the desktop and mobile layouts or the typography table I've created.
  • I've included some of the leaf titles on desktop as a way to test.

I'm moving forward with Overlock as it was more promising than Ubuntu as far as its base scale and kerning.

Note: the site title/display font is out of scope for this issue, I'll address it in another issue soon.

@jhimpele
Copy link
Contributor

Looks good. I have a few related points, perhaps for next week: the tradition and events "rows" or bands can be removed. Should we keep the branch names as placed above them? And there will only be one item on the trunk (the plaque). And let's continue our discussion of how to make the trunk appear as a single trunk...shading? Otherwise, I think we are looking good with Overlock!

@rlskoeser
Copy link
Contributor

@gissoo the sizes all look good to me; everything seems very readable and I like how the Overlock is working out; glad it was a good solution for the sizing.

In the table of font sizes and styles, under navigation, you have "mobile: footer default" repeated, I think the second one should be selected (it looks like you forgot to change the name, I can tell from the styles).

You list buttons and tags in the nav section, do they use the same type styles as footer default?

It looks like these are ready to implement, would you create an implementation issue when you close this design issue?

@gissoo gissoo changed the title Propose type sizes for each content type on desktop Propose type sizes for each content type on desktop and mobile Jan 23, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Jan 23, 2023

@jhimpele thank you for writing. I have removed the traditions and events and left one circle as an indicator for the plaque in the trunk. The revised tree style will be in a separate issue. About the placement of the leaf labels I'm not sure, having a difficult time seeing them all placed the same way, it would be helpful to test that in implementation because the spacing within the visualization displayed in Figma won't be matching the implementation.

@gissoo
Copy link
Contributor Author

gissoo commented Jan 23, 2023

@rlskoeser thanks for writing! I have fixed the table, yes, they will use the same type styles and footer default, I've fixed the label so it says tags and footer. But we don't have text "buttons". I'll eliminate that

@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Jan 23, 2023
@gissoo gissoo closed this as completed Jan 23, 2023
@gissoo gissoo reopened this Jan 23, 2023
@gissoo gissoo closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants