Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user on mobile when I select a tag on the tag index page I want to see my selected tag directly below the tree, without any other details on the page #161

Closed
gissoo opened this issue Apr 19, 2023 · 4 comments
Assignees

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 19, 2023

@rlskoeser When testing the index page on mobile I noticed the following:

  • when I select a tag and I'm taken to the tree page the active tag appears below the footer
  • there is an open panel of the project intro below the active tag

Here is the design on figma that we agreed on

It's happening on all browsers, below is the issue on chrome mobile emulator:
Screenshot 2023-04-19 at 11.14.10 AM.png

@rlskoeser
Copy link
Contributor

@gissoo I thought I had fixed that problem with the intro partially showing. I see now that it's visible when you scroll, and that shouldn't be the case.

Did I interpret the design correctly? You're kind of cheating because you're not showing the full height, I assumed that you intended the tag to be at the bottom of the screen. How does the tag without an active leaf display with the footer? I think some of the footer will be visible on some devices, is this intended/desired?

@gissoo
Copy link
Contributor Author

gissoo commented Apr 19, 2023

@rlskoeser I was hoping the footer wouldn't be visible, I understand if it's impossible. I think the tag should appear above the footer even if it's stuck directly to the top of the footer.

@rlskoeser
Copy link
Contributor

@gissoo I was thinking sticking the tag to the top of the footer might be a reasonable solution (if the footer is visible). I think it would be hard for the footer not to be visible, but perhaps we can look at it together.

🤔 if the footer is not visible, we're going to have a scroll trap (zoom trap)....

@rlskoeser
Copy link
Contributor

completed in #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants