-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revise the site title in the site header #168
Comments
@rlskoeser @jhimpele what do you think about the revision? Please comment your thoughts about the size of the fonts and spacing, here is the desktop version and here is the mobile – are we keeping tagline on the header on mobile? |
@gissoo fonts and spacing look fine to me. I like the italics for the tagline. If the tagline is in Overlock then it won't need to be an image, which is nice. I'd rather not give that much space to the header on mobile, is putting the tagline in the beginning of the intro panel still an option? |
This is really nice to see, @gissoo. I do think the font size on the tagline could be a little larger, without causing it to fall on three lines in mobile. Can we see it a little larger? Thanks! |
thank you for your comments, @rlskoeser and @jhimpele @jhimpele I'm hesitant about increasing the size:
I don't like this new revision on mobile and desktop @jhimpele following on Rebecca's question: do we want to consider putting the tagline inside the intro panel at all on mobile? |
hi @gissoo I do like the larger font on the desktop. It doesn't look diminished, nor too big. It's hard to judge the mobile since it's not constrained by the screen. But if you think the tag line works better in the panel, that's fine. Wouldn't it nevertheless take up the same vertical space? |
Putting the tagline in the panel takes up the same vertical space when the page loads, but it's space we get back once we collapse the intro or open a leaf. |
That’s a great idea!
|
@rlskoeser @jhimpele here are the changes I've made on desktop and mobile – please let me know what you think:
|
@gissoo and @rlskoeser Great work. The only thing that I'm still not sure of is having the subtitle in the mobile intro panel. It's a little confusing to me. Also, on both desktop and mobile, are we going to have an English translation in parens and smaller font? An * with translation at bottom? |
@jhimpele regarding translation for the welcome text Keely mentioned that to me yesterday when she reviewed the designs. I would suggest something like this – what do you think? |
Looks good. Do you think it should be same size font as the main body text?
|
@jhimpele I like the way it looks, and I'm also refraining from creating a new type style just for that, let me know if you think it needs to have a different style |
It works fine! Thanks.
|
I agree with Jeff that the tagline in the panel on mobile is too confusing, especially now that we have the welcome text and the information about how to use the viz. I think we should just put it in the header and not worry about the extra space. I'm sorry for causing extra work by suggesting we make that change in the first place... Based on the Lenape slack conversation, we have a change in language now. I think it will still fit here. The bold for the welcome text makes it look like a heading. Did you consider using italic? Also, did you consider any visual separation between the welcome and the intro text? (like a horizontal rule or something) I do think these work ok, and don't want to overcomplicate things. |
@rlskoeser @jhimpele thank you both for reviewing. Based on your comments I have reviewed the designs, below are the specific updates:
Please let me know if you're okay with these revisions so I can place the new titles as svgs on github. |
Great job @gissoo! I like! We add the credit to Kristen Jacobs through GitHub? |
Wonderful! I think we're ready to run with these versions. @jhimpele yes, all the text for the intro panel will be in a content document in github, so we can handle the credit that way. I can set it up when I implement the revised title and add the welcome. |
Excellent! Thanks.
|
thank you both for your reviews!! I have uploaded the site title svgs to github! I'll go ahead and close this issue. |
No description provided.
The text was updated successfully, but these errors were encountered: