Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise the site title in the site header #168

Closed
gissoo opened this issue Apr 24, 2023 · 19 comments
Closed

revise the site title in the site header #168

gissoo opened this issue Apr 24, 2023 · 19 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Apr 24, 2023

No description provided.

@gissoo gissoo added 🗺️ design Tracks design work in an external app 🛠️ chore One-off task or update labels Apr 24, 2023
@gissoo gissoo self-assigned this Apr 24, 2023
@gissoo gissoo removed the 🛠️ chore One-off task or update label Apr 25, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Apr 25, 2023

@rlskoeser @jhimpele what do you think about the revision? Please comment your thoughts about the size of the fonts and spacing, here is the desktop version and here is the mobile – are we keeping tagline on the header on mobile?

@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Apr 25, 2023
@rlskoeser
Copy link
Contributor

@gissoo fonts and spacing look fine to me. I like the italics for the tagline.

If the tagline is in Overlock then it won't need to be an image, which is nice.

I'd rather not give that much space to the header on mobile, is putting the tagline in the beginning of the intro panel still an option?

@jhimpele
Copy link
Contributor

This is really nice to see, @gissoo. I do think the font size on the tagline could be a little larger, without causing it to fall on three lines in mobile. Can we see it a little larger? Thanks!

@gissoo
Copy link
Contributor Author

gissoo commented Apr 26, 2023

thank you for your comments, @rlskoeser and @jhimpele

@jhimpele I'm hesitant about increasing the size:

  • even though the number of lines wouldn't increase on mobile there are two factors that increase the overall height of the header container by 6px.
  • based on my bit of research it would be better if the tagline in the header is smaller than our H1 sizes.

I don't like this new revision on mobile and desktop

@jhimpele following on Rebecca's question: do we want to consider putting the tagline inside the intro panel at all on mobile?

@jhimpele
Copy link
Contributor

hi @gissoo I do like the larger font on the desktop. It doesn't look diminished, nor too big. It's hard to judge the mobile since it's not constrained by the screen. But if you think the tag line works better in the panel, that's fine. Wouldn't it nevertheless take up the same vertical space?

@rlskoeser
Copy link
Contributor

Putting the tagline in the panel takes up the same vertical space when the page loads, but it's space we get back once we collapse the intro or open a leaf.

@jhimpele
Copy link
Contributor

jhimpele commented Apr 27, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented May 8, 2023

@rlskoeser @jhimpele here are the changes I've made on desktop and mobile – please let me know what you think:

  1. the title on desktop and mobile have changed to "Lunaapahkiing Princeton Timetree"
  2. the subtitle is on the header on desktop and inside the panel on mobile
  3. I've added the temporary welcome text as the panel's header on desktop and mobile
  4. on mobile the welcome text is above the subtitle, and the subtitle is placed more closely to the description
  5. Made the subtitle larger as we agreed
  6. After our meeting I thought of proposing this: we make the "Princeton Timetree" smaller only on mobile so that it wouldn't take so much space on the header

@jhimpele
Copy link
Contributor

jhimpele commented May 9, 2023

@gissoo and @rlskoeser Great work. The only thing that I'm still not sure of is having the subtitle in the mobile intro panel. It's a little confusing to me. Also, on both desktop and mobile, are we going to have an English translation in parens and smaller font? An * with translation at bottom?

@gissoo
Copy link
Contributor Author

gissoo commented May 9, 2023

@jhimpele regarding translation for the welcome text Keely mentioned that to me yesterday when she reviewed the designs. I would suggest something like this – what do you think?

@jhimpele
Copy link
Contributor

jhimpele commented May 10, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented May 10, 2023

@jhimpele I like the way it looks, and I'm also refraining from creating a new type style just for that, let me know if you think it needs to have a different style

@jhimpele
Copy link
Contributor

jhimpele commented May 10, 2023 via email

@rlskoeser
Copy link
Contributor

I agree with Jeff that the tagline in the panel on mobile is too confusing, especially now that we have the welcome text and the information about how to use the viz. I think we should just put it in the header and not worry about the extra space. I'm sorry for causing extra work by suggesting we make that change in the first place...

Based on the Lenape slack conversation, we have a change in language now. I think it will still fit here.

The bold for the welcome text makes it look like a heading. Did you consider using italic?

Also, did you consider any visual separation between the welcome and the intro text? (like a horizontal rule or something)

I do think these work ok, and don't want to overcomplicate things.

@gissoo
Copy link
Contributor Author

gissoo commented May 15, 2023

@rlskoeser @jhimpele thank you both for reviewing. Based on your comments I have reviewed the designs, below are the specific updates:

on mobile:

  1. the site title and subtitle are both in the site header
  2. the "PRINCETON TIMETREE" portion of the header is a bit smaller to help save some vertical space
  3. I've reduced the line height between "LUNAAPAHKIING" and "PRINCETON TIMETREE" to help save vertical spacing
  4. The new welcome text has been added, revised it so that it's bold italics now, and the translation fits on the same line with an 8px horizontal spacing (thanks for suggesting that, Rebecca!)

On desktop:

  1. everything in the header is the same as before
  2. the new welcome text and translation are added and are placed on the same line, again with an 8px horizontal spacing

Please let me know if you're okay with these revisions so I can place the new titles as svgs on github.

@jhimpele
Copy link
Contributor

Great job @gissoo! I like! We add the credit to Kristen Jacobs through GitHub?

@rlskoeser
Copy link
Contributor

Wonderful! I think we're ready to run with these versions.

@jhimpele yes, all the text for the intro panel will be in a content document in github, so we can handle the credit that way. I can set it up when I implement the revised title and add the welcome.

@jhimpele
Copy link
Contributor

jhimpele commented May 15, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented May 15, 2023

thank you both for your reviews!! I have uploaded the site title svgs to github! I'll go ahead and close this issue.

@gissoo gissoo closed this as completed May 15, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants