-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup percy visual review workflow #18
Comments
@rlskoeser thank you! Can we do 320px and 1440px for screen sizes? I was doing some research yesterday and found out it's still better to design in 1440 than 1280, I'll revise my figma mockups as well. |
@gissoo sure! Let me figure out where to configure that, I'll revise and let you know |
@rlskoeser The other thing I'm noticing is how on the Percy screenshots the upper leaves, the trunk and some lower leaves are cut off. |
yes, there are still some display issues — I'm planning to handle them under a separate task; maybe it makes sense to do as part of the headers & footers? I want to get your input on how to size the viz container. Here's the new build for this branch with the sizes you requested |
@rlskoeser thank you, that makes sense. the mobile is 330px though, could we make it 320px? |
wow, sorry! I thought I copied your sizes exactly, IDK how I messed that up. Thanks for catching. Here's the latest build, I just confirmed that it's 320 now instead of 330. |
thank you!! |
Adapt from geniza; start with homepage (should eventually have one content page also). At least mobile + desktop; maybe a tablet size also.
The text was updated successfully, but these errors were encountered: