Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace VizE lab logo in the footer #189

Closed
gissoo opened this issue May 9, 2023 · 10 comments
Closed

Replace VizE lab logo in the footer #189

gissoo opened this issue May 9, 2023 · 10 comments
Assignees
Labels
🛠️ chore One-off task or update 🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented May 9, 2023

No description provided.

@gissoo gissoo added 💬 awaiting review Ready for comments and questions 🗺️ design Tracks design work in an external app 🛠️ chore One-off task or update labels May 9, 2023
@gissoo gissoo self-assigned this May 9, 2023
@gissoo
Copy link
Contributor Author

gissoo commented May 9, 2023

@jhimpele I placed the new logotype in the footer and here you can see what it looks like if we don't change the sizes

here is how I would suggest the sizes change to fit the logotype in the footer

Note: If you're more likely to keep the current logotype format, i.e. all the PU and VizE lab text beneath the logo then the links above will still be pretty accurate, but if you are thinking of removing some text then the overall height of the logotype will decrease and therefore what you see in the links above will not be accurate. All depends on how you'll revise the logotype.

@jhimpele
Copy link
Contributor

hi @gissoo. I'm not seeing a difference between the sizes! the two links are taking me to the same page in figma. It looks like it would work better with out the Princeton University line, which is not readable, and we could expand everything.

@gissoo
Copy link
Contributor Author

gissoo commented May 10, 2023

@jhimpele they are on the same Figma page, they are different but more subtle on desktop than mobile, here:
Screenshot 2023-05-10 at 1 15 06 PM

and here
Screenshot 2023-05-10 at 1 15 29 PM

@jhimpele if you'd like to remove the PU line please revise the logotype and make any adjustments necessary and share the revised svg file with me. I agree with removing it, the PU line is also not necessary here since the PU logo almost always can accompany department/center logos.

@jhimpele
Copy link
Contributor

jhimpele commented May 10, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented May 10, 2023

@jhimpele putting it to the side might work better, but the readability of PU may remain as is since it's also in a very light weight.

@jhimpele
Copy link
Contributor

jhimpele commented May 10, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented May 15, 2023

@jhimpele @rlskoeserI've updated the footer with the newest VizE lab logo Jeff sent me later last week. What do you think? I like this version of the logo much more than the previous ones, thanks to you and Lula, Jeff.

I changed the alignment on mobile so they are right aligned, because visually way more pleasing than the center – aligning them in the center with the new VizE lab logo doesn't work well.

@jhimpele
Copy link
Contributor

jhimpele commented May 15, 2023 via email

@rlskoeser
Copy link
Contributor

The right alignment on mobile is interesting! Almost reverse stair steps. I trust you that it doesn't work centered, I could see how they might fight with each other a bit.

These are fine with me, let's move forward with this update.

@gissoo
Copy link
Contributor Author

gissoo commented May 15, 2023

Thank you, both! The new VizE lab logo has been uploaded to github. @rlskoeser, the logo's width on mobile is 180px, and height on desktop is 50px. These can be inspected on Figma. I'll go ahead and close this issue.

@gissoo gissoo closed this as completed May 15, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ chore One-off task or update 🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants