Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize javascript / leaf layout #212

Closed
rlskoeser opened this issue May 19, 2023 · 2 comments
Closed

optimize javascript / leaf layout #212

rlskoeser opened this issue May 19, 2023 · 2 comments
Labels
🛠️ chore One-off task or update

Comments

@rlskoeser
Copy link
Contributor

lighthouse complains about the time to render the page; would be good if we can optimize somehow

wondering if we could apply initial positions to the leaves to speed up the force layout
@rlskoeser
Copy link
Contributor Author

Changes in #226 included a higher alpha decay value for the force simulation, and the layout now completes in 30 ticks instead of 300 ticks. I don't know how much this optimizes things overall, but the force layout should be much faster now.

@rlskoeser rlskoeser added the 🛠️ chore One-off task or update label Nov 2, 2023
@rlskoeser
Copy link
Contributor Author

this was resolved by the solution implemented in May; comments from code review confirmed the load time is sufficiently performant and we're already using the recommended approach for optimizing layout speed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🛠️ chore One-off task or update
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlskoeser