Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose logic for zoom levels based on the labels on the leaves on desktop and mobile #35

Closed
Tracked by #67
gissoo opened this issue Jan 4, 2023 · 4 comments
Closed
Tracked by #67
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Jan 4, 2023

This issue tracks design work through the CDH design review workflow.

Here is a link to the

Description:

How the proposal/idea can fail:

Questions:

  1. Does the idea and/or the design make sense to you? If not, please say why
  2. Is there anything that you expected to see and is missing?

Additional context
Add any other context or screenshots about the design here.

@rlskoeser
Copy link
Contributor

@gissoo would you consider this to be complete based on our conversation and decisions yesterday?

@gissoo
Copy link
Contributor Author

gissoo commented Mar 29, 2023

I think so! @rlskoeser

Below are some of the main decisions we made:

  • no zoom on desktop
  • pinch to zoom on mobile
  • Don’t show leaf labels on default mobile view; show at first zoom level
  • 4 levels of zoom (on level 4 the size of the leaves seems to be good/almost accessible while being able to see more leaves)
  • on zoom we should not let the svg go beyond our defined borders (so we do not see empty space beyond the century labels or extra space on the right side of the svg, beyond the last R+R leaf)
  • When a leaf is clicked at any zoom level, zoom in to level 4 while centering on that leaf; may need to center higher in case the leaf panel overlaps
  • When leaf panel is closed (x), leave the tree zoomed in on whatever zoom level it is on
  • We should design and implement a button to reset zoom (go back to the default zoom level)

@rlskoeser
Copy link
Contributor

Thank you @gissoo !

Just to confirm, regarding "no zoom on desktop" - is this based entirely on screen size? Does it matter whether or not it is a touch device?

@gissoo
Copy link
Contributor Author

gissoo commented Apr 10, 2023

@rlskoeser I forgot to respond to your comment! I think it needs to be entirely based on the screen size, because all the leaves do fit on the desktop size, so interacting with the leaves by fingers should still be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

2 participants