Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user I want to read an introduction to the project before engaging with the tree so that I can navigate it with more understanding and intention. #54

Closed
gissoo opened this issue Feb 1, 2023 · 7 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Feb 1, 2023

What's in scope:

  • The visual style of the project intro
@gissoo gissoo added the 🗺️ design Tracks design work in an external app label Feb 1, 2023
@gissoo gissoo self-assigned this Feb 1, 2023
@gissoo gissoo changed the title As a user I want to understand the project better before engaging with the tree and the content so that I can navigate it with more understanding and intention. As a user I want to read an introduction to the project before engaging with the tree so that I can navigate it with more understanding and intention. Feb 7, 2023
@gissoo gissoo added the 💬 awaiting review Ready for comments and questions label Feb 7, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Feb 7, 2023

@rlskoeser @jhimpele I'd like to know if you're still okay with the visual style of the project intro and how it's displayed like a panel. On desktop it's vertically placed a bit lower in the panel because it's exactly like the other leaf panels but without the "x" button at the top (I've hid the x button), I think not moving the text higher in the panel makes transitioning between content smoother and avoids content from shifting up and down. Let me know what you think, here is the design on figma

@rlskoeser
Copy link
Contributor

@gissoo I think this looks good, but could you put an example of the panel content next to these so I can see the differences you're describing? It's hard for me to get by toggling between this view and the other panel designs.

@jhimpele
Copy link
Contributor

jhimpele commented Feb 8, 2023

I see what you mean.....What if there were a faded (e.g. inactive X there) that become darker and active on the actual panels? The spacing on the landing to the site does look awkward.....

@gissoo
Copy link
Contributor Author

gissoo commented Feb 8, 2023

@jhimpele I don't think showing a faded x makes sense because it could imply that it can sometimes be enabled for the intro panel, whereas not showing it means it would never be enabled on the intro panel.

@rlskoeser @jhimpele I made these two prototypes: (to interact with the first page click on any leaf, then click on the "x" to go back to the previous page)
1. this one is keeping the top marginal space the same for either container
2. this one is customizing the top marginal space for the intro container.

So this was helpful, I don't see any shifting of content that I expected to see – but I just don't think customizing the spacing is necessary here, because the spacing visually works for me – I'm ok if you feel strongly, so let me know.

@rlskoeser
Copy link
Contributor

@gissoo I prefer not having to customize the spacing! Glad you think it isn't necessary.

@jhimpele
Copy link
Contributor

jhimpele commented Feb 8, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Feb 15, 2023

We've agreed to keep the same top margin within all the panels. I've cleaned up the figma file so it reflects our decision. I'll go ahead and close

@gissoo gissoo closed this as completed Feb 15, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants