-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user I want to read an introduction to the project before engaging with the tree so that I can navigate it with more understanding and intention. #54
Comments
@rlskoeser @jhimpele I'd like to know if you're still okay with the visual style of the project intro and how it's displayed like a panel. On desktop it's vertically placed a bit lower in the panel because it's exactly like the other leaf panels but without the "x" button at the top (I've hid the x button), I think not moving the text higher in the panel makes transitioning between content smoother and avoids content from shifting up and down. Let me know what you think, here is the design on figma |
@gissoo I think this looks good, but could you put an example of the panel content next to these so I can see the differences you're describing? It's hard for me to get by toggling between this view and the other panel designs. |
I see what you mean.....What if there were a faded (e.g. inactive X there) that become darker and active on the actual panels? The spacing on the landing to the site does look awkward..... |
@jhimpele I don't think showing a faded x makes sense because it could imply that it can sometimes be enabled for the intro panel, whereas not showing it means it would never be enabled on the intro panel. @rlskoeser @jhimpele I made these two prototypes: (to interact with the first page click on any leaf, then click on the "x" to go back to the previous page) So this was helpful, I don't see any shifting of content that I expected to see – but I just don't think customizing the spacing is necessary here, because the spacing visually works for me – I'm ok if you feel strongly, so let me know. |
@gissoo I prefer not having to customize the spacing! Glad you think it isn't necessary. |
Agree! Great job @gissoo.
|
We've agreed to keep the same top margin within all the panels. I've cleaned up the figma file so it reflects our decision. I'll go ahead and close |
What's in scope:
The text was updated successfully, but these errors were encountered: