-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design spacing for century containers #68
Comments
@rlskoeser here are the specs for century spacing. |
@gissoo I did a little bit of looking at this in tandem with trying to get the svg sizing adjusted so it fits at a 1.0 scale when the page is 1280 wide. I don't think 42px is big enough, the leaves are bigger than that and don't fit very well within those bands. The leaves look too big to me on my actual implementation at that scale, and they don't fit in the layout without a lot of overlap. It looks sort of reasonable on your mockup, although I can't tell from your design which leaves belong in which century. But you only have 28 leaves on this version (I counted); I currently have 102 leaves and I haven't imported the latest version of the data yet. Please provide spacing starting from the top of the timetree container. In your mockup they don't go all the way up to the top — I don't understand why that is. Please clarify. I'm not sure what you mean about them starting 42-45 px above the trunk, I don't see how that works in the design you linked — but I think it is less important if you can give me spacing from the top of the container. In the mockup you shared the century labels have a a wider left margin and the leaves go further to the edge — that is the reverse of what I would expect (labels outside of the leaves / leaves not covering over the labels). |
@rlskoeser thank you for this – would have been easier to talk through this at our co-working session last week – the numbers I gave you above were after factoring in the given heights of the trunk and the roots but I agree with your comments, it's creating problems on the higher end of the tree. You can see the changes I've made here on Figma and hopefully the placement of the leaves are matching the logic I've made the following revisions:
let me know if these are helpful. |
we've made some decisions at PR #81 and at our co-working session which have changed some of the numbers above:
|
No description provided.
The text was updated successfully, but these errors were encountered: