Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose a color for the panel on desktop and mobile that would be easier on the eyes and be visually pleasing with respect to the rest of the page #77

Closed
gissoo opened this issue Feb 7, 2023 · 18 comments
Assignees
Labels
🗺️ design Tracks design work in an external app

Comments

@gissoo
Copy link
Contributor

gissoo commented Feb 7, 2023

What's in scope:

  • the color of the panel
@gissoo gissoo self-assigned this Feb 7, 2023
@gissoo gissoo added 💬 awaiting review Ready for comments and questions 🗺️ design Tracks design work in an external app labels Feb 7, 2023
@gissoo
Copy link
Contributor Author

gissoo commented Feb 7, 2023

@rlskoeser @jhimpele I'd like your opinion on the color of the panel. The light version is too stark and makes it harder to look at after some time, therefore I thought of proposing the dark version that matches the color of the header and the footer. Here are the versions on figma for desktop and mobile.

@rlskoeser
Copy link
Contributor

@gissoo I see what you mean now about the light version being too stark.

If you think the dark background is distinct enough for this use, then I'm ok with it. I like it visually, I just wonder about contrast / emphasis — I think this should be visually more important than header or footer.

The tag background color looks too bright on the dark background.

@jhimpele
Copy link
Contributor

jhimpele commented Feb 8, 2023

Agree with @rlskoeser here. I prefer the dark panel, and would darken the tag backgrounds too. I might suggest a panel that is shaded somewhere in between the tree background and the header/footer, and the same for the tag background.

But for the sake of intelligibility and simplicity, I think we ought to avoid adding too many more colors/shades. So: keep the panel dark as is, but darken the tag background....

@gissoo
Copy link
Contributor Author

gissoo commented Feb 8, 2023

@rlskoeser @jhimpele so helpful!! Yikes, don't know why I didn't think of changing the color on the tag containers, it's not the right system for this dark version – I'll do that, thanks.

I was 100% thinking of the relation between the panel, header, and footer and wasn't comfortable but also with the colors on the tree I found that matching the panel with the header and the footer may be the safer route to go – let me do a quick digging on this and will get back to you.

@gissoo
Copy link
Contributor Author

gissoo commented Feb 13, 2023

@jhimpele @rlskoeser I've revised the color of the tag containers (selected and default), please take a look here and let me know what you think Note: the only thing in scope here is the visual styling of the tags

  • also, I tried lighter shades (then the dark brown) for the panel but they all fail accessibility contrast requirements for small text size (which we have in the panel), the only ones that pass are very close to this dark brown that I've shown you. I think we should go with this.

Let me know if you have any concerns or we can close this issue

@rlskoeser
Copy link
Contributor

@gissoo this looks fine to me

@jhimpele
Copy link
Contributor

jhimpele commented Feb 13, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

@jhimpele the filled-in checkmark is when a tag is selected/acitve, and the outlined one is how it looks by default/not selected.

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

@jhimpele your comment reminds me: when one is selected (filled-in) the others are outlined and faded (30%opacity), when no tag is selected all of them are outlined and 100%. I just made the change on Figma link above so you can see.

@jhimpele
Copy link
Contributor

@gissoo Thanks for clarifying. What confuses me is that there is already a checkmark in the circle before anything is selected. I intuitively expect the circle to be empty, and then selecting something (i.e. the tag) ticks the circle with a checkmark. Here, there seems to be three rather than two ways of interpreting a circle. Can we just do empty + checked when used, however you think looks best in terms of outline and opacity? Thanks!

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

@jhimpele I don't think that's a good idea, because the outlined checkmark makes it clearer that you can interact with the tags, otherwise it's not clear that the capability exists. An empty circle is not visually familiar to the users' eyes because it's currently not used anywhere in UIs – that's why the color distinction can be a clearer option than adding/subtracting from the icon.

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

@jhimpele what you're suggesting could have worked for filters but it's trickier for tags that appear inside a panel, below descriptions.

@jhimpele
Copy link
Contributor

jhimpele commented Feb 14, 2023 via email

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

@jhimpele I understand.

  • I can look for other icons that could work better. (let me see)
  • I'd like to avoid changing the font weight, it often creates issues, creating little shifts within the container.
  • Yes, usability-wise we'll need to clearly indicate when a tag is active, especially because one can be directed to that view since it's going to have its own URL. And more generally anything that you can interact with needs to visually reflect that. They won't remain checked /active once you refresh the page or if you select a different panel. They may remain checked/be preserved if you go to another page but use the browser's back button to get back to the page. Note that as we mentioned only one tag can be selected at a time.

I think this discussion is going beyond the scope of this issue. We can track this discussion in issue #55 and close this issue.

@rlskoeser
Copy link
Contributor

fwiw, I don't love the checkmarks either, it makes it look more like a filter (which isn't quite right), and it also clutters/distracts from the text. They seemed ok so I didn't bring it up. But don't they look enough like buttons without that? Could we use color to indicate currently selected tag? I do agree it's valuable to have an indicator of which tag is selected.

@gissoo
Copy link
Contributor Author

gissoo commented Feb 14, 2023

ok, let's discuss this in issue #55. Thanks for the comments. I can propose other styles for tags that rather incorporate all requirements and feedback on both sides.

@jhimpele
Copy link
Contributor

@gissoo I now understand and agree with being able to see which tag is active at any time.

A highlighted background color on the tag would work very well.

@gissoo gissoo closed this as completed Feb 14, 2023
@gissoo gissoo removed the 💬 awaiting review Ready for comments and questions label Feb 14, 2023
@jhimpele
Copy link
Contributor

jhimpele commented Feb 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ design Tracks design work in an external app
Projects
None yet
Development

No branches or pull requests

3 participants