Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodicals with numbers not sorting in numerical order #666

Closed
clmahoney opened this issue Jun 10, 2020 · 5 comments
Closed

Periodicals with numbers not sorting in numerical order #666

clmahoney opened this issue Jun 10, 2020 · 5 comments
Labels

Comments

@clmahoney
Copy link

Describe the bug
If the periodical has numbers but no volumes, the numbers are not saved in numerical order.

To reproduce
See 4585, "New Writing," which does not have vols but has numbers:
Screen Shot 2020-06-10 at 12 28 42 PM

Expected behavior
Numbers should be listed in numerical order. A secondary sort field would help resolve this.

@clmahoney clmahoney added the bug label Jun 10, 2020
@clmahoney clmahoney reopened this Jun 10, 2020
@clmahoney
Copy link
Author

Nevermind I think I just did something wrong! This is working now!

@rlskoeser
Copy link
Contributor

@clmahoney I'm not sure what you figured out, it would be good to document if you can. Based on the information in the database I don't think the sort you want is guaranteed. In this case, couldn't you use dates to indicate the proper sorting? We only display year, but the field allows year/month or year/month/day.

@clmahoney
Copy link
Author

@rlskoeser I see. I couldn't use dates because this was a seasonal magazine, so the year was the same but it was divided into Spring/Autumn spreads.

@clmahoney
Copy link
Author

@rlskoeser For some reason when I deleted the seasons that were out of order and added them back in, they were in the right order! (Again, same year, just different seasons)

@rlskoeser
Copy link
Contributor

@clmahoney what I was trying to say is that you can add approximate months corresponding to the seasons in the date — they will be used for sorting but only the year will be displayed.

@rlskoeser rlskoeser added wontfix and removed bug labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants