Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to see the actual rather than digital page number on keyword search results of Gale/ECCO items so that I can more accurately cite items. #446

Closed
2 tasks done
rlskoeser opened this issue Jul 27, 2022 · 1 comment
Assignees
Milestone

Comments

@rlskoeser
Copy link
Contributor

rlskoeser commented Jul 27, 2022

testing notes

Import a new record in #370 and then check on the public site how the page numbers display; if possible, test a record that you know has folioNumbers set in the Gale API (some of them don't have it set, others seem to just be set based on the digital image number)

dev notes

update indexing to use new page number from updated api

  • update gale_page_index_data method to set label from new Gale API folioNumber field
  • update test for this method to match
@rlskoeser rlskoeser added this to the v3.8 milestone Jul 27, 2022
@rlskoeser rlskoeser self-assigned this Aug 10, 2022
@mnaydan
Copy link
Contributor

mnaydan commented Aug 17, 2022

This appears correct! I tested with CB0131069855 with keyword "salubrious," which appears on digital page range 118 but shows a physical page number of 4. On main search and search within volume pages the result correctly labels the thumbnail p. 4. Double checked with CW0101863745 and search "Sicily" (digital page 10, actual page 7) and the display was also correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants