Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer versions of wagtail/django/python #496

Closed
6 tasks done
quadrismegistus opened this issue Nov 22, 2022 · 9 comments
Closed
6 tasks done

Upgrade to newer versions of wagtail/django/python #496

quadrismegistus opened this issue Nov 22, 2022 · 9 comments
Assignees
Labels

Comments

@quadrismegistus
Copy link
Contributor

quadrismegistus commented Nov 22, 2022

Some notes here on wagtail/django version conflicts I ran into which we might want to solve later.

testing notes

  • edit and create some pages with wagtail and check that things work as expected
  • wagtail "chooser" has changed; check that you can add a person to the contributor page
  • autocomplete requires configuring search; check that you can search people on the person snippet list, and that adding a person to contributor page works with partial names

test collection choices on archive search page:

  • confirm all collections are present and default deselected collections display as expected
  • confirm toggling collection filters works as expected
  • add a new collection in the database with no works; confirm it shows up on on the archive list but is disabled (dimmed and can't be selected)
@mnaydan mnaydan added the chore label Jan 16, 2024
@rlskoeser rlskoeser changed the title Upgrading wagtail/django Upgrade to newer versions of wagtail/django/python Feb 1, 2024
@rlskoeser rlskoeser self-assigned this Feb 1, 2024
@mnaydan
Copy link
Contributor

mnaydan commented Feb 12, 2024

I poked around on Django and Wagtail and I think things look good! Two issues:

  1. Partial search for snippets works, but only for names that I just created. Search is not working for old/existing snippets.
  2. I'm not sure if this is related to the upgrade or I discovered a different bug but "True" is showing up as a collection after I added a new collection:
    Screenshot 2024-02-12 at 12 57 28 PM

FYI, the new option to "Show counts" in Django is very handy.

@rlskoeser
Copy link
Contributor

@mnaydan I must have forgotten to update the wagtail index! I made a note in the deploy notes that we need to do this when we deploy the update but with all the staging site woes I must have lost track. I just ran it now - partial search on older snippets should work now. (I also ran the command to update references - this is how wagtail keeps track of where an image or other resources is used).

I'll look into the weird "True" collection.

@mnaydan
Copy link
Contributor

mnaydan commented Feb 12, 2024

@rlskoeser thanks! the partial search is working now for snippets and images. Let me know whether the "True" collection is related to the upgrade or a separate bug.

@rlskoeser
Copy link
Contributor

@mnaydan I think the "True" collection must be related to the upgrade - not sure what's causing it yet, but I remember making some changes to the relevant part of the code when I worked on the upgrade. I'm glad you spotted it!

@mnaydan
Copy link
Contributor

mnaydan commented Feb 14, 2024

Good news: "True" collection is no longer showing up, and selecting/deselecting yields results now as expected (no more collections=label in the URL for the case I describe above).

A couple problems:

  • When I change the default deselected collections on admin, they're not appearing auto-deselected on the frontend.
  • The new collection I added ('Second Test') did not show up at all until I added a work to it.

@rlskoeser
Copy link
Contributor

@mnaydan just to check: could you / did you try the checks that didn't work with a hard refresh? The last modified time is based on the solr index, which the collection changes you made wouldn't affect so the browser cache could be obscuring this.

@mnaydan
Copy link
Contributor

mnaydan commented Feb 14, 2024

@rlskoeser ooh good call, I did not -- thank you for suggesting, I'll do that now.

@mnaydan
Copy link
Contributor

mnaydan commented Feb 14, 2024

@rlskoeser aha! That's exactly what it was. Sorry I didn't think of that! Those two checks are now working.

@mnaydan mnaydan closed this as completed Feb 14, 2024
@rlskoeser
Copy link
Contributor

@mnaydan oh good! Thanks for confirming. I do think it's ok for the last-modified to ignore these kinds of db changes, since it's not too likely to happen often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants