-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to newer versions of wagtail/django/python #496
Comments
@mnaydan I must have forgotten to update the wagtail index! I made a note in the deploy notes that we need to do this when we deploy the update but with all the staging site woes I must have lost track. I just ran it now - partial search on older snippets should work now. (I also ran the command to update references - this is how wagtail keeps track of where an image or other resources is used). I'll look into the weird "True" collection. |
@rlskoeser thanks! the partial search is working now for snippets and images. Let me know whether the "True" collection is related to the upgrade or a separate bug. |
@mnaydan I think the "True" collection must be related to the upgrade - not sure what's causing it yet, but I remember making some changes to the relevant part of the code when I worked on the upgrade. I'm glad you spotted it! |
Good news: "True" collection is no longer showing up, and selecting/deselecting yields results now as expected (no more collections=label in the URL for the case I describe above). A couple problems:
|
@mnaydan just to check: could you / did you try the checks that didn't work with a hard refresh? The last modified time is based on the solr index, which the collection changes you made wouldn't affect so the browser cache could be obscuring this. |
@rlskoeser ooh good call, I did not -- thank you for suggesting, I'll do that now. |
@rlskoeser aha! That's exactly what it was. Sorry I didn't think of that! Those two checks are now working. |
@mnaydan oh good! Thanks for confirming. I do think it's ok for the last-modified to ignore these kinds of db changes, since it's not too likely to happen often. |
Some notes here on wagtail/django version conflicts I ran into which we might want to solve later.
testing notes
test collection choices on archive search page:
The text was updated successfully, but these errors were encountered: