Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning hathi pairtree data is fragile: breaks on .DS_Store, additional or missing files #534

Closed
quadrismegistus opened this issue Mar 21, 2023 · 2 comments
Closed

Scanning hathi pairtree data is fragile: breaks on .DS_Store, additional or missing files #534

quadrismegistus opened this issue Mar 21, 2023 · 2 comments
Assignees
@quadrismegistus
Labels
chore

Comments

@quadrismegistus
Copy link
Contributor

Setting up an issue here to track this PR: #529

I've run into a few errors when scanning through the HATHI_DATA folder. If there's a .DS_Store in there, as happens on macs if that folder is ever opened via Finder, or if a single work has a missing .zip file, then the entire indexing or other process (often parallel processes, which break even more messily) will break.
@quadrismegistus quadrismegistus self-assigned this Mar 21, 2023
@quadrismegistus
Copy link
Contributor Author

This issue also occasioned this closed PR: #515

@mnaydan
Copy link
Contributor

mnaydan commented Jan 10, 2024

Fixed by PR #515

@mnaydan mnaydan closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quadrismegistus quadrismegistus

Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quadrismegistus @mnaydan