-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a visualization to communicate the difference between Jingdian Shiwen, dictionaries, and essays. #314
Comments
@thatbudakguy @rlskoeser @GDRom what do you think about this version I put together loosely based on your sketch Nick, for comparing the three different approaches? I've been looking at it for too long, I'm sure it can be improved |
here's a bunch of thoughts about this in no particular order:
|
@thatbudakguy thank you for your detailed comments and suggestions!
|
@thatbudakguy @rlskoeser thank you both for your thoughtful feedback. I have revised it a little bit, but there are more issues that need to be addressed which I have not been able to get to this week, will put this issue in the backlog and get back to it later in July. |
I think this can be closed. Rather than trying to illustrate the difference between dictionaries, commentaries, and the JDSW, I think it'll be easier to just show an image of an actual (printed) copy of the JDSW, and then indicate to the user what the parts look like on the page. |
Notes:
For this visual we should show something that communicates the difference between the two or three versions (JDSW vs. dictionaries vs. essays)
The text was updated successfully, but these errors were encountered: