-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design a way to convey five different types of textual annotation so that readers can understand model annotations of Jingdian Shiwen #320
Comments
@gissoo here's a quick sketch of the different elements in @thatbudakguy's draft for figure 7: @thatbudakguy can you confirm that:
|
sorry, I feel like there's so much going on here...maybe some context will help. the primary text from the Book of Changes is describing how the sixty-four hexagrams that comprise the Book itself were originally "generated". here's what a hexagram looks like: as you can see, it's formed from six horizontal lines, which are either solid ("strong") or broken ("weak"). there are 64 permutations of six such lines, so the text is basically saying "when you take a solid or broken line and repeat it six times, and get every unique version of that, you get the 64 hexagrams." they look like this: when using the Book of Changes as an oracle, you construct a hexagram that is more or less your "fortune" for that moment. (incidentally, the Book figures prominently in PKD's The Man in the High Castle, and he actually used this method of fortune-telling to guide his writing process for that book). |
i think this particular example was created by hand, but i just checked and the model produces this same output, so yes. |
@rlskoeser @gwijthoff below are details of what I have done for figure 7. When viewing the links, please zoom out to scan the mobile versions too. Here is the latest version, v3 on desktop and mobile. Here is version 2 on desktop and mobile. – The only difference between 2.2 and 2.1 on desktop is the style of the legend.
|
@gissoo I love this! The various underline symbols are so readable and clear and I think will be very accessible. Is your plan to export assets I can include as a repeating pattern under the designated terms? I like the alternating gray and white in v3 but I prefer the legend separate as you have it on v2.2 instead of interspersed with the text. If you want to keep it interspersed with the text, maybe we could flip the order so the annotation label is after the translation? For mobile I like v3.1 - I think it is more readable to keep the underlines consistent with desktop, and I think it will also be easier to implement. I guess it's harder to do a separate legend on mobile... and I'd rather be consistent between desktop and mobile. I don't think it's worth the effort to use the purple style, I think that will detract - the white and gray with the different indicators looks really clean and readable to me. |
This is fantastic work, thanks @gissoo! I agree with @rlskoeser that the legend is probably better separate, as in v2.2. For mobile, also in agreement preferring v3.1, though if possible, without the "phonetic" "people" tags etc., instead just using a vertically stacked legend like the one you designed in v2.1 desktop? To answer your other question, I think it is important to Nick & Gian to include the original/primary text portion, which the Jingdian Shiwen passage you've underlined comments on. |
Wow...these are so cool!! I'm blown away. A few thoughts; I had different reactions from @gwijthoff and @rlskoeser but not sure if that matters here & I'm happy to go with whatever.
|
@rlskoeser @gwijthoff @thatbudakguy thank you for your feedback – below are my responses and thoughts:
So I have revised the version 3 both on desktop and mobile so that based on Rebecca's suggestion the annotation labels come after the translation (with a bit more spacing), thank you, I think this is so much better! Here is the desktop version and here is mobile v3.3 and mobile v3.2 Please let me know what you think and if you feel strongly about anything written above. Question: sorry trying to understand this better, so we are including the primary text like this in this viz? |
Authorial preference takes precedent! I approve all @thatbudakguy's suggestions above and like that he and @gissoo are in agreement about the direction for this mind-blowingly cool figure. So exciting to see, through this visualization, all of the many different ways that a text can contain information.
@thatbudakguy correct me if I'm wrong, but I believe the answer is yes |
In my initial mockups I had included it, but for this figure specifically, @GDRom suggested removing it, because it's somewhat long and might distract readers from the focus, which is the text from the JDSW itself. I think I might agree — we really are only interested in the headword (相摩) which is that two-character part of the original text that is underlined. |
@rlskoeser I've got an idea for how to do the vertical underlines (? does that even make any sense? sidelines?) and might take another pass at this this week. |
I vote for with excluding the initial explanatory text and focus on the relevant portion only. I like it much better with annotation labels under the translation text. I'm ok with doing that instead of a legend on mobile (which would be hard to make work well anyway). @thatbudakguy I think I'm losing track of versions but happy to go with the one you like - I take it you like the vertical bars on mobile rather than horizontal? I think this can be done with a border-image and Gissoo will provide the pattern images to use, so it's not difficult. (It's probably possible to do with pure css but not sure it's worth the effort, unless you want to take that on.) Do we have any decisions left? Can we document what we've agreed on and make an implementation issue? |
@gissoo I think everyone has reviewed and commented and we're ready to move forward. Can you create an implementation issue for me and make it clear in Figma which version we're going with, and export/upload any assets that are needed? You can close this issue when that's done. @gissoo Please flag if there is anything that is still not decided or unclear. @thatbudakguy if you want to work on this or help implement, please LMK. I think the structure you've already got in the html will make it fairly easy to apply the new styles. |
@rlskoeser @thatbudakguy @gwijthoff thank you for your feedback! @thatbudakguy that makes sense to me now about the specific part of the primary text, how about this? https://www.figma.com/file/MEt3gfKX4N3WTLPbLGBbGC/Startwords?type=design&node-id=4857%3A3153&mode=design&t=HKTUdGdHqSU6K6oG-1 – I made it clear what part of the text you're annotating ...if not I can just go with the version I proposed originally without the primary text line. In the meantime I'll prep the final versions for hand off. |
@rlskoeser While I wait for Nick's response, here is the finalized version on desktop and on mobile. I will go ahead and create an implementation issue for this figure. |
I do like the visual hint about what part of the primary text is being annotated (it's definitely clearer than the underline). However, I think if we included the primary text, we would also need to include its translation and its source info (like I did in the original draft of the figure). That adds a lot of stuff to the figure, which is why I think it might be too distracting. Let's keep the final version you have now. |
Thanks, @thatbudakguy. @rlskoeser I'll go ahead and close the issue. I have revised the underlines to almost match what Nick has done. Here is the desktop and here is the mobile – It might be better to make both the dashed line and the solid line's width to be 6px and the works annotation to be one thick line with a 12px width. |
This issue tracks design work through the CDH design review workflow.
Here is a link to the
Description:
Review Nick's draft for figure 7:
https://jdsw-figures.glitch.me/annotations
Is highlighting the best solution here? How can we include a key or legend to make the types of annotations more clear? How do we make this information accessible?
How the proposal/idea can fail:
Questions:
Additional context
Potential overlap with #319
The text was updated successfully, but these errors were encountered: