treewide: Cleanup. Reduce the number of warnings issued during test execution #2541
Conversation
It's an obsolete alias to 'float', use that instead. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Original time: 247 usecs. Optimizations: * Use numpy array operations for sin, these are faster than Python iterations. Time: 214 usecs * Use numpy array operations for sin and cos, these are faster than Python iterations. Time: 191 usecs * Use numpy cumsum instead of complete product with partial divisions, this is both faster and more accurate. it also avoids potential issue with division by zero. Time: 180 usecs Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…iable Avoids zero values in distance computation during initialization. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Empty list creates empty elementwise comparison which is false and deprecated. Add an explicit check to avoid that. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
… if available The latter are deprecated in Python 3.8+. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…n construction The latter is deprecated. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
No reason to test the construction again with no execution. Simplify generation of test names. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…nflict between mech and function parameter Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
It's not used in the test and PsyNeuLink warns about it. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…self This is a common situation in tests that assign the same object to e.g. default variable, and then variable for execution. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This removes most "DeprecationWarning:" messages (GA jobs go from ~36k to ~17k). The ones that remain are:
UserWarnings were reduced to (when running
|
| @@ -440,7 +440,8 @@ def iscompatible(candidate, reference=None, **kargs): | |||
| try: | |||
| with warnings.catch_warnings(): | |||
| warnings.simplefilter(action='ignore', category=FutureWarning) | |||
| if reference is not None and (candidate == reference): | |||
| # np.array(...).size > 0 checks for empty list. Everything else create single element (dtype=obejct) array | |||
| if reference is not None and np.array(candidate, dtype=object).size > 0 and (candidate == reference): | |||
There was a problem hiding this comment.
No issue with this, but we could potentially also use
| if reference is not None and np.array(candidate, dtype=object).size > 0 and (candidate == reference): | |
| if reference is not None and np.array(candidate, dtype=object).size > 0 and safe_equals(candidate, reference): |
although safe_equals would need a couple small changes because I think the type of warning produced by that == check has changed since it was written
There was a problem hiding this comment.
I had the same idea [0,1], but it gave enough errors to leave it for the next time.
Most of the remaining warnings (in total number) are from the elementwise comparison and np.matrix so it's definitely worth revisting.
[0] https://github.com/jvesely/PsyNeuLink/actions/runs/3492618053
[1] https://ci.appveyor.com/project/jvesely/psyneulink-cuda/builds/45417908/job/m8adfgaec8pfs27u
There was a problem hiding this comment.
Ah ok, makes sense. I can make those changes separately then, they're not many.
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Update patterns that cause Python warnings at runtime
np.float. The existing use cases already consider basicfloat,np.floatis just a deprecated alias of that.