Free boats

[HeavenIsLost]

Able to choose if free boats or not and some fixes in boats Npcs( costs, need premium, voices, and some keywords ).

[EPuncker]

I still don't like this implementation, better edit the StdModule.travel instead as I said in your another pull request, if it got added I'll just skip updating travel npcs because of the way you added too much code for just a cost change, I still don't see the option to disable premium and quest check :/ better to pull it once all is completed

[HeavenIsLost]

Too much job to pull everything in one time. I just want to have a option to have free or paid boats. Of course, you are right, stdModule.travel implementation 1000 more clean than this, but it would fuck the messages, because we need to have the message with the cost of travel and the message without the cost of the travel, it cannot be implemented in a custom manner for every npc with stdModule.travel, its why i have done what i have done. Disabling the need to have premium could be done directly on stdModule.travel( using luaFlags ). The options to disable/enable quest check could be done with luaFlags( just add one variable to luaFlags table and do the code to check if player has the quest/mission required and the need is enabled on luaFlags, we can do this in the future ). Its a WIP. Its not too much code, its just duplicate.

[tarantonio]

In my opinion, the way to go is:

• If you have free premium on config.lua, then you have free boats.
• Else you have to pay for travels.

[PrinterLUA]

Maybe we should done, something like this:
http://pastebin.com/gF3PaeBY

To cut the code alot.

[HeavenIsLost]

If you want to in do this way( dynamic ), i think i have a better way:
local travelNode = keywordHandler:addKeyword({'thais'}, StdModule.sayPaidFree, {npcHandler = npcHandler, onlyFocus = true, text = 'Do you seek a passage to Thais %s?', textPaid = "for 180 golds",textFree = "for free"})

It would choose if use TextPaid or TextFree based on luaFlags.freeBoats = true

@EPuncker

Quest check:

local travelNode = keywordHandler:addKeyword({'yalahar'}, StdModule.sayQuestCheck, {npcHandler = npcHandler, onlyFocus = true, text = 'Do you seek a passage to Yalahar for 240 golds?', questCheck = { enabled = luaFlags.accessToYalahar, storage = Storages.accessToYalahar, value = 2 } }})

Instead of doing a stdModule.say to questCheck and another to paid or free we can implement everything in normal stdModule.say.

[EPuncker]

dude why not focus on fixing existing content and adding new content so then we can finally think on adding features? :/

[PrinterLUA]

Well, we could edit the modules. But i have never take a look into the npc libs. So i would not dare to change there ^^

[HeavenIsLost]

I can do this, i will work on this and then i will make a new pull request in this subject( again! ).

[PrinterLUA]

Haha heaven, sorry bro :) But thanks that you are doing this ^^ I love the spirit in you!

[Royalot]

i think with printers script we can fix this #698 issue, too

[EPuncker]

I like @PrinterLUA script lol :D I see no problem in adding it to all npcs, also instead of freeTravel setting, just edit it so if price = 0 then it act as if freetravel were true =P

[HeavenIsLost]

My new proposal is better than Printer one, more clean than use creaturecallbacksay.

[EPuncker]

@HeavenIsLost where is it? xD

[PrinterLUA]

I took look into the stdmodule, if you ask me. It's not even the best idea to use stdmodule, its so badly made.

But here it is, i also converted it to metatables:
http://pastebin.com/JHJM44dU

And here is the example how the captain module should look:
http://pastebin.com/NHV7UEva

Free travel, such as prem and price cost will be free if you have setted on config.lua freePremium = "yes".

If you want use the other solution, which is updated than the other one above:
http://pastebin.com/CVr7J1ve