Adding ISSUE_TEMPLATE and new pull_request Template #132
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeel-codder
changed the title
RunDevelopment
requested changes
Sep 10, 2021
There was a problem hiding this comment.
Thank you for the PR @zeel-codder!
Could please also add another issue template for other issues? Not all issues we had in the past fall under the bug and docs categories. I'm thinking of something simple like this:
---
name: Other
about: An issue or question that doesn't fit in the other categories
---
(Feel free to add a fitting emoji.)
Regarding the PR template: We have more than just PRs that add new themes. I think a template as simple as the following might be enough.
<!--
Before submitting your PR, please make sure that all tests pass.
You can run all tests using `npm test`.
-->
|
I make the changes As per your advice. |
RunDevelopment
requested changes
Sep 11, 2021
|
I make the changes. if you want me to add more issue templates or anything else feel free to tell me, I will happy to do that. |
RunDevelopment
approved these changes
Sep 12, 2021
|
Thank you very much for contributing @zeel-codder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeel hear, In this pull request, I add the two custom new ISSUE TEMPLATE and also the new theme add pull request.
Thank you