Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop shortcuts cause Segmentation Fault #1229

Closed
1 task done
doinkythederp opened this issue Jun 19, 2023 · 5 comments · Fixed by #1302
Closed
1 task done

Desktop shortcuts cause Segmentation Fault #1229

doinkythederp opened this issue Jun 19, 2023 · 5 comments · Fixed by #1302
Labels
bug Something isn't working macOS Issues and PRs related to macOS specifically
Milestone

Comments

@doinkythederp
Copy link

doinkythederp commented Jun 19, 2023

Operating System

macOS, Linux

Version of Prism Launcher

Prism Launcher 7.1

Version of Qt

Qt 6.5.0

Description of bug

Desktop shortcuts of Minecraft Instances do not successfully start the game. Instead, they open a terminal window showing a segmentation fault error message.
34987

Steps to reproduce

  1. Click "Add Instance", select "Vanilla", and click "OK"
  2. Click "Create Shortcut"
  3. Close Prism Launcher
  4. Double-click the file created on the desktop

Suspected cause

It seems related to downloading assets. This also seems specific to the --launch command line flag and doesn't happen when using the app manually.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@doinkythederp doinkythederp added the bug Something isn't working label Jun 19, 2023
@sadespresso
Copy link

sadespresso commented Jun 21, 2023

I also have the same issue on KDE Desktop (KDE Neon 5.27)

The problem occurs both on CLI, and .desktop links, but launching the instance through Prism Launcher (no links, no arguments) works as expected

Steps and suspected cause is same as this issue.

OS: KDE Neon 5.27
Prism Launcher Version: 7.1
Command: ./prismlauncher --launch 1.20.1
Logs:

...
...
...
    2.727 D | [launcher.task]: Task "NetJob(Libraries for instance Intro City ID: b1fd7ae6-99a1-4d53-a055-121141ddc4f7)" starting for the first time
     2.728 D | [launcher.task]: Task "NetJob(Libraries for instance Intro City ID: b1fd7ae6-99a1-4d53-a055-121141ddc4f7)" succeeded
     2.728 D | [launcher.task]: Task "LibrariesTask(0x5607c0d496a0 ID: 4e97f97f-72d3-47c3-8530-f2f484fecd74)" succeeded
     2.728 D | [launcher.task]: Task "FMLLibrariesTask(0x5607c0d351a0 ID: b00f629e-75d2-47b7-95b5-84e882c7c974)" starting for the first time
     2.728 D | [launcher.task]: Task "FMLLibrariesTask(0x5607c0d351a0 ID: b00f629e-75d2-47b7-95b5-84e882c7c974)" succeeded
     2.728 D | [launcher.task]: Task "AssetUpdateTask(0x5607c0d48a40 ID: 9ae2b50e-e924-4524-a802-0298c9d13ab8)" starting for the first time
     2.728 D | Asset index SHA1: "9d58fdd2538c6877fb5c5c558ebc60ee0b6d0e84"
     2.728 D | "Intro City" : Starting asset index download
     2.729 D | [launcher.task]: Task "NetJob(Asset index for Intro City ID: 7dcea6cc-d846-4492-9e44-2fd8c4c37441)" starting for the first time
     2.732 D | [launcher.task]: Task "Net::Download(CACHE:https://piston-meta.mojang.com/v1/packages/9d58fdd2538c6877fb5c5c558ebc60ee0b6d0e84/5.json ID: b12ab7d9-96dd-4597-aa44-ffbe2f22d19d)" starting for the first time
Segmentation fault

@DioEgizio
Copy link
Member

i can reproduce

@doinkythederp doinkythederp changed the title Desktop shortcuts cause Segmentation Fault on macOS Desktop shortcuts cause Segmentation Fault Jun 21, 2023
@42Willow
Copy link

I can reproduce on Windows.
image
I don't know how to view the launcher console though.

@sadespresso
Copy link

sadespresso commented Jun 22, 2023

I also just found out if you have a currently open Prism Launcher window, and use the shortcut (or thru cli), it [correctly] launches the desired Minecraft instance.

@Ryex Ryex added this to the 7.2 milestone Jul 2, 2023
@Ryex Ryex added the macOS Issues and PRs related to macOS specifically label Jul 2, 2023
@Ryex
Copy link
Contributor

Ryex commented Jul 3, 2023

@doinkythederp
can I get you to test a nightly build?
https://github.com/PrismLauncher/PrismLauncher/actions/runs/5440563742
or
https://nightly.link/PrismLauncher/PrismLauncher/actions/runs/5440563742

Another user on dicord provided macos logs of the segfualt and I was able to determine a possible cause

@Ryex Ryex closed this as completed in #1302 Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS Issues and PRs related to macOS specifically
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants