Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Plugins? #1240

Open
1 task done
TheKidThatCodes opened this issue Jun 21, 2023 · 6 comments
Open
1 task done

[RFC] Plugins? #1240

TheKidThatCodes opened this issue Jun 21, 2023 · 6 comments
Labels
rfc Request for comment

Comments

@TheKidThatCodes
Copy link

Goal

to add plugin capability.

Motivation

im coding my own mod platform and i want to be able to add it to prism as a develop it. there is also a lot of empty space in the sidebar with modrinth and curse

Specification

plugins can add new places to get mods and packs from and can have their own config.
my idea of how a plugin could get the data is the plugin would be used by prism with os.system or whatever that is in c(++)(im a python developer so this would make me easily able to make my plugin). then the plugin returns the data through stdout to prism and it displays it in the list

Drawbacks

would this add a vulnerability for malware?

Unresolved Questions

would this add a vulnerability for malware?

Alternatives Considered

idk

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

No response

@TheKidThatCodes TheKidThatCodes added the rfc Request for comment label Jun 21, 2023
@TheKodeToad
Copy link
Member

I thought it would be a good idea to be able to add self-hosted instances of modrinth...

@TayouVR
Copy link
Member

TayouVR commented Jun 21, 2023

I think Qt has some kind of plugin system, and it would be neat to modularize some of our codebase that way. mainly for adding more than just mod platforms though. Plugins could do more funky and weird things like add support for minecraft bedrock instances or something

@TheKodeToad
Copy link
Member

If a plugin is going to have configuration, I don't think using stdin/stdout is viable

@TayouVR
Copy link
Member

TayouVR commented Jun 21, 2023

if we implement plugins I think this is the only reasonable choice: https://doc.qt.io/qt-6/plugins-howto.html#the-low-level-api-extending-qt-applications

@Mai-Lapyst
Copy link

Hi; I would like to work on this (tbh I already tinker around a little with it); is anyone else already working on this?

@Trial97
Copy link
Member

Trial97 commented Nov 19, 2023

Go for it. I am not working on this and presuming if another person had started working it would have opened a draft at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Request for comment
Projects
None yet
Development

No branches or pull requests

5 participants