Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher crashes on clicking edit on any instance - Instance-type specific settings were loaded! #1328

Closed
1 task done
LackingCats opened this issue Jul 8, 2023 · 6 comments · Fixed by #1332
Closed
1 task done
Labels
bug Something isn't working
Milestone

Comments

@LackingCats
Copy link

LackingCats commented Jul 8, 2023

Operating System

Linux

Version of Prism Launcher

PrismLauncher Flatpak 8.0-develop commit 3211b26 (latest as of now)

Version of Qt

Qt 5.15.10

Description of bug

Upon trying to edit any instance, the launcher crashed.

Steps to reproduce

  • Open Launcher
  • Click Instance
  • Click Edit

Suspected cause

I'm not sure of the cause, however it always ends with Instance-type specific settings were loaded! after trying to clear the cache.
Attached below is PrismLauncher-0.log
PrismLauncher-0.log

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@LackingCats LackingCats added the bug Something isn't working label Jul 8, 2023
@LackingCats
Copy link
Author

also this occurs for every instance

@LackingCats
Copy link
Author

This issue is not present on version 7.1

@Ryex
Copy link
Contributor

Ryex commented Jul 8, 2023

I can not replicate this. (I was headed to bead but I got back up to see if I could track this down)

however I found some minor issues with the commit that was just merged that might have side effects related.
so if you can test and see if you can replicate on #1329 that would be great.

@Ryex
Copy link
Contributor

Ryex commented Jul 8, 2023

it would be great if you could ensure that your instances are not broken or invalid
also if you could try some of the previous commits to see if you can narrow down where this issue originates

@TheKodeToad
Copy link
Member

I can reproduce this.

WideBar::insertActionAfter WideBar.cpp:120
ModFolderPage::ModFolderPage ModFolderPage.cpp:92
CoreModFolderPage::CoreModFolderPage ModFolderPage.cpp:265
InstancePageProvider::getPages InstancePageProvider.h:41
PageContainer::PageContainer PageContainer.cpp:87
InstanceWindow::InstanceWindow InstanceWindow.cpp:71
Application::showInstanceWindow Application.cpp:1429
MainWindow::on_actionEditInstance_triggered MainWindow.cpp:1282
MainWindow::qt_static_metacall moc_MainWindow.cpp:336
MainWindow::qt_metacall moc_MainWindow.cpp:414
void doActivate<false>(QObject*, int, void**) 0x00007ffff6ce832f
QAction::triggered(bool) 0x00007ffff79a7d24
QAction::activate(QAction::ActionEvent) 0x00007ffff79aab7b
QAbstractButtonPrivate::click() 0x00007ffff7aab91a
QAbstractButton::mouseReleaseEvent(QMouseEvent*) 0x00007ffff7aaba58
QToolButton::mouseReleaseEvent(QMouseEvent*) 0x00007ffff7bafb66
QWidget::event(QEvent*) 0x00007ffff79f3688
QApplicationPrivate::notify_helper(QObject*, QEvent*) 0x00007ffff79aeb75
QApplication::notify(QObject*, QEvent*) 0x00007ffff79b7456
QCoreApplication::notifyInternal2(QObject*, QEvent*) 0x00007ffff6cb4188
QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) 0x00007ffff79b56a4
QWidgetWindow::handleMouseEvent(QMouseEvent*) 0x00007ffff7a0d1a9
QWidgetWindow::event(QEvent*) 0x00007ffff7a1072f
QApplicationPrivate::notify_helper(QObject*, QEvent*) 0x00007ffff79aeb75
QCoreApplication::notifyInternal2(QObject*, QEvent*) 0x00007ffff6cb4188
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) 0x00007ffff716cc6b
QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) 0x00007ffff714acfc
xcbSourceDispatch(_GSource*, int (*)(void*), void*) 0x00007ffff30814d6
g_main_context_dispatch 0x00007ffff571339c
g_main_context_iterate.isra 0x00007ffff5771438
g_main_context_iteration 0x00007ffff5710a23
QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) 0x00007ffff6d06729
QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) 0x00007ffff6cb2b4b
QCoreApplication::exec() 0x00007ffff6cbaddb
main main.cpp:90
__libc_start_call_main 0x00007ffff6449b4a
__libc_start_main_impl 0x00007ffff6449c0b
_start 0x0000000000481535

@LackingCats
Copy link
Author

Thank you :)

@Ryex Ryex closed this as completed in #1332 Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants