Empty accounts list message doesn't correctly reflect the UI

[MMK21Hub]

Operating System

Linux

Version of Prism Launcher

PrismLauncher 7.1
34d80a8

Version of Qt

5.12.8

Description of bug

When viewing the Accounts tab of Settings, and there aren't any registered accounts, a message is shown to instruct the user on how to add an account:

Welcome!
If you're new here, you can click the "Add" button to add your Mojang or Minecraft account.

However, this message references "The "Add" button", which isn't a button that exists in the Accounts UI. In addition, it doesn't mention Microsoft (MS) accounts, which are now used by the majority (?) of players. For context, there are three different buttons for adding accounts: Add Microsoft, Add Mojang and Add Offline.

Since legacy Minecraft accounts are increasingly rare (if they even still function), and Offline accounts require an Online account to be added first, it seems sensible to mention Mojang and MS accounts in this message. For example:

Welcome!
If you're new here, click the "Add Microsoft" button to sign in, or "Add Mojang" to use an old Mojang account.

The phrasing above points the user towards MS accounts as a primary option, which are used by "millions" of players. As an alternative, the option below is more similar to the current message (but a bit more verbose):

Welcome!
If you're new here, you can click the "Add Microsoft" button to add your Microsoft account, or "Add Mojang" to add your Mojang account.

Steps to reproduce

1. Hide your registered accounts by renaming PrismLauncher/accounts.json to PrismLauncher/accounts.json.bak
2. Open Prism Launcher
3. Navigate to File > Settings > Accounts

Suspected cause

I assume that at some point in the past, the launcher simply had an "Add" button to add a Mojang/Minecraft account, but this was re-done when support for Microsoft accounts was added, without updating the new-user message.

The message is defined in AccountListPage.cpp.

Screenshot

[MMK21Hub]

I've just realised that Mojang accounts do, in fact, still function. I've updated the issue description accordingly.

[TheKodeToad]

This is a very easy task! if you have any git/github knowledge it'd be appreciated if you could change the string :P

[MMK21Hub]

Sounds good - I'll take a look at making a PR! I'll use the first suggested message unless y'all have another preference.

[TheKodeToad]

Maybe

Welcome! If you're new here, you can click the "Add Microsoft" or "Add Mojang" button to log in.

[MMK21Hub]

That sounds good!

[dannydorazio]

PR created— used grep to search through files and find two other instances of "minecraft account".
#1551