Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord RPC integration? #232

Closed
1 task done
hazelthatsme opened this issue Oct 22, 2022 · 9 comments
Closed
1 task done

Discord RPC integration? #232

hazelthatsme opened this issue Oct 22, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@hazelthatsme
Copy link
Contributor

hazelthatsme commented Oct 22, 2022

Role

I use it as my main method of playing Minecraft, and like people knowing how I'm playing.

Suggestion

I want Prism Launcher to forward the player status (what instance is running, what version, how long they've been playing, possibly how many mods are installed) to Discord Rich Presence.

Benefit

This could allow for a more universal way to announce your status to Discord friends, rather than downloading mods for different versions.

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

I do think if it is implemented it might do good to have a flag per instance, in case the user does prefer to have status updates from a mod in their instance.

In terms of determining what instance is running, maybe the last launched?

Adding the option for custom Discord application tokens, just like the Microsoft authentication, would also be great!

@hazelthatsme hazelthatsme added the enhancement New feature or request label Oct 22, 2022
@snoweuph
Copy link

We Need this

@mads985
Copy link

mads985 commented Nov 6, 2022

would love this

@PixelHir
Copy link

PixelHir commented Feb 2, 2023

This would be awesome, we have mods but you would need to install them separately for each instance and set configs.

@TheKodeToad
Copy link
Member

Discord's SDK is unforunately closed source... but there are some open source reimplementations out there! I'm not sure if there's a C++ one though.

@TheKodeToad
Copy link
Member

TheKodeToad commented Feb 2, 2023

After doing some research it seems like the old https://github.com/discord/discord-rpc still works fine.

@TheKodeToad
Copy link
Member

Little update: it seems like this is unlikely to be a feature in the launcher as mods can do this better.

@PixelHir
Copy link

PixelHir commented Jul 5, 2023

Little update: it seems like this is unlikely to be a feature in the launcher as mods can do this better.

Thats assuming user has mods, what if they don’t?

@Scrumplex
Copy link
Member

We can not add Discord's RPC SDK to Prism Launcher as it's proprietary and therefore incompatible with our software license.
Apart from that, the launcher doesn't know a lot of what you are doing in-game, so any Discord RPC mod is going to be able to provide more information than the launcher. I would therefore say that this is out of scope for Prism Launcher.

@Scrumplex Scrumplex closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2023
@TheKodeToad
Copy link
Member

https://github.com/MultiMC/Launcher/blob/develop/libraries/launcher/org/multimc/onesix/OneSixLauncher.java#L81
Maybe we should implement something like this?
Maybe in the Prism namespace - although multimc could be added too for compat I suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants