Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTB App Import #235

Closed
1 task done
spookytea opened this issue Oct 22, 2022 · 18 comments · Fixed by #1359
Closed
1 task done

FTB App Import #235

spookytea opened this issue Oct 22, 2022 · 18 comments · Fixed by #1359
Labels
enhancement New feature or request
Milestone

Comments

@spookytea
Copy link

Role

Playing curseforge packs

Suggestion

Import from FTB App

Benefit

Easier to install without having to manually install mods

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

No response

@spookytea spookytea added the enhancement New feature or request label Oct 22, 2022
@DioEgizio
Copy link
Member

how is installing a separate electron buggy launcher better than just using the one you're currently using? i don't agree

@TheAirBlow
Copy link

TheAirBlow commented Nov 5, 2022

@DioEgizio does the FTB App bypass Curse ToS or does FTB have some special agreement with Curse? Can you please explain this?

@DioEgizio
Copy link
Member

They have a deal with overwolf. In fact, that's why part of the ads in it goes to overwolf/creators

@Poopooracoocoo
Copy link

how is installing a separate electron buggy launcher better than just using the one you're currently using? i don't agree

For some people it's easier than using the CF workaround in Prism.
MultiMC has implemented FTB App importing, might I add. See their wiki and their post.
And as discussed on the Prism Launcher Discord server, it takes a long time to load FTB modpacks in Prism Launcher.

@DioEgizio
Copy link
Member

It takes a long time to load FTB modpacks in Prism Launcher.

As much if not less than the FTB app

@TheAirBlow
Copy link

how is installing a separate electron buggy launcher better than just using the one you're currently using? i don't agree

For some people it's easier than using the CF workaround in Prism. MultiMC has implemented FTB App importing, might I add. See their wiki and their post. And as discussed on the Prism Launcher Discord server, it takes a long time to load FTB modpacks in Prism Launcher.

The CF workaround works perfectly. Just get some addon like Fast Forward, which will skip the 5 second delay. Additionally, it will skip other annoyances like adfly, and warn you about IP loggers.

@TheAirBlow
Copy link

Following up, they implemented all of that because they had problems with Curseforge API ToS (as said in their post), and probably something similar with FTB. So it was a targeted attack on that launcher, because it's not giving them the yummy ad money.

@DioEgizio
Copy link
Member

We'll need this because of #1040

@DioEgizio DioEgizio pinned this issue May 2, 2023
@Nik-Kot
Copy link

Nik-Kot commented Jun 9, 2023

Isn't MultiMC already capable of importing FTB app packs? Can we port the code from there and adapt it?

@DioEgizio
Copy link
Member

Isn't MultiMC already capable of importing FTB app packs? Can we port the code from there and adapt it?

No because mspl

@Nik-Kot
Copy link

Nik-Kot commented Jun 14, 2023

Isn't MultiMC already capable of importing FTB app packs? Can we port the code from there and adapt it?

No because mspl

The license says some parts are Apache 2.0 and only some are MSPL. Concidering how similar the code would be if we wrote it from a scratch - this is worth looking into.

Edit: I have noticed the files themselves have MSPL license. This is bad (and why?).

@DioEgizio
Copy link
Member

Isn't MultiMC already capable of importing FTB app packs? Can we port the code from there and adapt it?

No because mspl

The license says some parts are Apache 2.0 and only some are MSPL. Concidering how similar the code would be if we wrote it from a scratch - this is worth looking into.

Edit: I have noticed the files themselves have MSPL license. This is bad (and why?).

No, every new file is mspl
And yes it is bad, mspl and GPL are incompatible, so we can't use them here

@Nik-Kot
Copy link

Nik-Kot commented Jun 14, 2023

No, every new file is mspl And yes it is bad, mspl and GPL are incompatible, so we can't use them here

Asked about this on MultiMC discord and found out tht they are against GPL because it is too invasive/restrictive. What a needess license battle while everyone authoring the code is not actually against forks using it.

@DioEgizio
Copy link
Member

This isn't the place for that endless drama. Just note that we can't pull from there nor they can pull from us. At this point every discussion about it is just useless drama that it's just a time waste

@Nik-Kot
Copy link

Nik-Kot commented Jun 14, 2023

This isn't the place for that endless drama. Just note that we can't pull from there nor they can pull from us. At this point every discussion about it is just useless drama that it's just a time waste

Sorry for this, was my first time encountering something like this. I can delete my comments if needed.

@mkaito
Copy link

mkaito commented Jul 21, 2023

One of the main reasons I use Prism, aside from it actually being a good launcher, is Apple Silicon support. While the FTB App runs on these chips, its Minecraft instances do not. Could you please keep this in mind when you get around to working on importing FTB instances?

@TheKodeToad
Copy link
Member

I don't think there will be an issue as they are converted into native prism instances (#1359)

@Scrumplex Scrumplex unpinned this issue Sep 16, 2023
@Scrumplex Scrumplex added this to the 8.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants