Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Setup: Do not change ‘Minimum memory’ based on ‘Maximum memory’ field #427

Closed
1 task done
brawaru opened this issue Nov 9, 2022 · 1 comment · Fixed by #1552
Closed
1 task done
Labels
bug Something isn't working
Milestone

Comments

@brawaru
Copy link

brawaru commented Nov 9, 2022

Operating System

Windows, macOS, Linux, Other

Version of Prism Launcher

Prism Launcher 5.1

Version of Qt

Qt 6.4.0

Description of bug

When entering into the field ‘Maximum memory allocation’ a number less than the number in ‘Minimum memory allocation’, the number in ‘Minimum memory allocation’ automatically updates to the number in ‘Maximum memory allocation’, creating frustrating experience where you have to go back and change value in ‘Minimum memory allocation’ again.

Would be better if this updating behaviour would only happen when ‘Maximum memory allocation’ field lost focus. Ideally, however, it should not happen at all, instead showing an error when user clicks the ‘Finish’ button that their ‘Maximum memory allocation’ is less than value in ‘Minimum memory allocation’, forcing them to notice and manually fix the mistake. The reason for the error rather than guess work is because this may slip through unnoticed, especially if the user relies on assistive technologies like screen reader that won't announce that ‘Minimum memory allocation’ value has been automatically updated.

Steps to reproduce

  1. Remove launcher configuration / start fresh installation to force quick setup to show.
  2. Select your language to proceed to problematic step.
  3. On Java step enter ‘256 (MiB)’ in ‘Minimum memory allocation’.
  4. Select everything in ‘Maximum memory allocation’ field and start entering ‘2048 (MiB)’ one digit at a time.

Observe as you enter the digit 4, that the value in field ‘Minimum memory allocation’ changes to match what's currently entered in ‘Maximum memory allocation’ field, thus to ‘204 (MiB)’.

GIF showing the author performing the aforementioned reproduce steps

Suspected cause

Poor design decisions.

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.
@brawaru
Copy link
Author

brawaru commented Aug 23, 2023

Thank you legend @Trial97!

@Scrumplex Scrumplex added this to the 8.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants