Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-name downloaded icons from platforms which don't get proper names #536

Closed
1 task done
IdrisQe opened this issue Dec 1, 2022 · 0 comments · Fixed by #1563
Closed
1 task done

Auto-name downloaded icons from platforms which don't get proper names #536

IdrisQe opened this issue Dec 1, 2022 · 0 comments · Fixed by #1563
Labels
enhancement New feature or request
Milestone

Comments

@IdrisQe
Copy link

IdrisQe commented Dec 1, 2022

Role

It's mostly just for aesthetics and easier sorting of icons in the selection menu

Suggestion

When downloading a modpack, take the pack name and use that as the name of the icon if it's from a platform which doesn't keep icon name metadata

Benefit

Again mostly just aesthetic and sorting benefits, not having a bunch of icons named "curseforge_[string_of_numbers]" everywhere

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

When downloading a modpack via the various website and launcher sections in the import menu, Prism Launcher imports the icon for the pack automatically. In many cases this works fine, specifically with FTB, FTB Legacy, and ATLauncher packs. But when installing packs from Curseforge or Technic, the icons will have unreadable names consisting of either:
curseforge_XXXXXXXXXXXXXXXXXX or technic_XXXXXXX (where any "X" is a number)
Modrinth has a lesser version of this where every icon is labelled as modrinth_name (where "name" is a lowercase representation of the pack, either an acronym or the name itself)

Given that Prism Launcher already generates a valid name for the pack at around the same time it grabs the icon (when the pack is first selected in the menu), I feel it wouldn't be too hard to save the icon with the name of the pack instead in cases where it would look better than the messy ID's used by Curseforge, Technic, and Modrinth.

I know this is an extremely minor complaint, but I feel like it wouldn't be too hard to do and would greatly improve the appearance of the Icon menu and folder after you've downloaded several packs from these places.

No change:
image
image

Where it would get the name:
image

After the change (With characters that can't be used by the filesystem removed/replaced):
image
image

(Note: File Explorer examples have had .png added at the end so the icon is visible in File Explorer)

@IdrisQe IdrisQe added the enhancement New feature or request label Dec 1, 2022
@Scrumplex Scrumplex added this to the 8.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants