Whole client crashes when installing a pack from ATLauncher

[BorealBlizzard]

Operating System

Linux

Version of Prism Launcher

Prism Launcher 6.3

Version of Qt

Qt 6.4.2

Description of bug

When downloading the Yogscast Complete Pack through ATLauncher the whole programs crashes when at the extracting stage.

Steps to reproduce

Add Instance
ATLaucher
Search "Yogs"
Yogscast Complete Pack
OK
Select Recommended (Also crashed when only installing what was checked by defualt)
Install
Wait For Crash

Suspected cause

No response

This issue is unique

• I have searched the issue tracker and did not find an issue describing my bug.

[Ryex]

can you provide the Prismlauncher-0.log from the launcher data directory?
It will help in ensuring we are dealing with the same issue if we replicate it.

[HyperSoop]

Can reproduce
PrismLauncher-0.log

[BorealBlizzard]

PrismLauncher-0.log

[Emily9121]

Same issue, with Windows 10 21H2 running Prism Launcher 6.3 and also tried with 5.2 without success.

PrismLauncher-3.log
PrismLauncher-1.log

[DioEgizio]

can reproduce

[Scrumplex]

This happens because of a race condition when loading component information. Specifically, if LiteLoader is used in a modpack.

If there is no locally cached metadata, the code will not wait for the load task to finish and will try to access version information right away.

Relevant code:

detecting LiteLoader here:

PrismLauncher/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp

Lines 503 to 509 in 09d607f

	if (liteLoaderMap.contains(lib.md5)) {
	auto ver = getComponentVersion("com.mumfrey.liteloader", liteLoaderMap.value(lib.md5));
	if (ver) {
	componentsToInstall.insert("com.mumfrey.liteloader", ver);
	continue;
	}
	}

loading metadata here:

PrismLauncher/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp

Lines 1041 to 1058 in 09d607f

	static Meta::Version::Ptr getComponentVersion(const QString& uid, const QString& version)
	{
	auto vlist = APPLICATION->metadataIndex()->get(uid);
	if (!vlist)
	return {};
	if (!vlist->isLoaded())
	vlist->load(Net::Mode::Online);
	auto ver = vlist->getVersion(version);
	if (!ver)
	return {};
	if (!ver->isLoaded())
	ver->load(Net::Mode::Online);
	return ver;
	}

using metadata here: (source of segfault)

PrismLauncher/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp

Line 606 in 09d607f

if(componentVersion->data()->mainClass != QString("")) {