Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Play support #975

Open
1 task done
Madis0 opened this issue Apr 5, 2023 · 11 comments
Open
1 task done

Quick Play support #975

Madis0 opened this issue Apr 5, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@Madis0
Copy link

Madis0 commented Apr 5, 2023

Role

User

Suggestion

Add an UI to instance settings to launch to a specific world/server

Benefit

Modpacks, players who play on one server/world a lot

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

See https://www.minecraft.net/en-us/article/minecraft-snapshot-23w14a for details

@Madis0 Madis0 added the enhancement New feature or request label Apr 5, 2023
@RaptaG
Copy link
Contributor

RaptaG commented Apr 5, 2023

It already exists for servers.

@456dev
Copy link

456dev commented Apr 5, 2023

the existing feature uses the old --server localhost --port 25565 format, which was removed in 23w14a, replaced with new args:
--quickPlaySingleplayer "New World"
--quickPlayMultiplayer "localhost:25565"
--quickPlayRealms "1234"

also I would like to see support for a command line argument to launch into a world/server/realm, not just an instance like at the moment

@byquanton
Copy link
Contributor

The system aroudn MinecraftServerTarget would need a rewrite.

@TheKodeToad
Copy link
Member

Seems like to keep the server-joining functionality you'd just need to change https://github.com/PrismLauncher/PrismLauncher/blob/develop/launcher/minecraft/MinecraftInstance.cpp#L567
Currently Minecraft does launch but ignores the old arguments
Completely ignored arguments: [--server, localhost, --port, 25565]

@RuiNtD
Copy link
Contributor

RuiNtD commented Jun 6, 2023

They also added a --quickPlayPath argument to log joined worlds / servers / realm to a specified JSON file. It would be nice to be able to enable a Quick Join option per-instance (or globally?) that would both enable the logging and change the Play button to a Quick Play button (only on 1.20+!), popping up a menu prompting for you to select a world / server / realm or just launch Minecraft normally. BTW, the logging also includes info on the world / server / realm name, game mode, and last played time, so here's what I'm thinking in terms of UI:

image

The Set Default option would turn off the Quick Play option and change the instance settings to just that quick play setting (unless Launch Normally is selected).

@MenacingPerson
Copy link
Contributor

Also can this be a dropdown or something instead of a simple text box? Thanks

@TheKodeToad
Copy link
Member

TheKodeToad commented Jun 12, 2023

The system aroudn MinecraftServerTarget would need a rewrite.

(removed some things because I was confused)

I suppose it could become a union.

@whitebear60
Copy link

Any updates on this one? As a workaround for now I modified my Minecraft instance's minecraftArguments in json, but that feels kinda janky and not right...

@TomatechGames
Copy link

this might warrent its own issue request, but it would be good to just have a textbox to append minecraft arguments to the ones generated by prism in case a change like this happens in a future version

@TomatechGames
Copy link

Any updates on this one? As a workaround for now I modified my Minecraft instance's minecraftArguments in json, but that feels kinda janky and not right...

which file contained the minecraftArguments variable?

@Fabian42
Copy link

Fabian42 commented Sep 4, 2023

Edit the profile/instance→Version→Minecraft→Edit, near the end. For me, that's ~/.local/share/PrismLauncher/instances/[name]/patches/net.minecraft.json, line 450 out of 462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants