Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Prism.Interactivity.PopupWindowAction.CreateDefaultWindow to virtual #1165

Closed
darinclarkdev opened this issue Sep 20, 2017 · 6 comments
Labels

Comments

@darinclarkdev
Copy link

Currently if you wish to provide your own implementation of DefaultConfirmationwindow and DefaultNotificationWindow you must override GetWindow in the child class. If CreateDefaultWindow was virtual like CreateWindow is you could override just the 2 methods and leave GetWindow in the base class.

@brianlagunas
Copy link
Member

We accept PR's :)

@roberszr
Copy link

roberszr commented Oct 5, 2017

Hi Brian,
I'm new on using Prism (6.3), and I've got a strange behavior when using PopupWindowAction . I would try to explain; I've got a module in which there is a third party library for a softphone (VoIP library). The problem is that if i show a PopupWindowAction, the third party library, VoIP library, gets blocked until i close the PopupWindow...Am I doing something wrong? Is the only way to do that? Is the third library wrong? I don't know what to do because i can't use PopupWindow on, for example, an incoming call...
Best rergards

@brianlagunas
Copy link
Member

brianlagunas commented Oct 5, 2017

I don't know as I am not familiar with your third party plugin or how it works.

@darinclarkdev
Copy link
Author

darinclarkdev commented Oct 5, 2017

Maybe launch a second shell instead of using a PopupWindowAction. Check out Infragistic's reference apps that emulate word, excel and outlook. They use prism with some advanced designs.

PS questions like this are probably better suited to prismlibrary.slack.com

@brianlagunas brianlagunas added this to the Prism 7.0 milestone Oct 6, 2017
@brianlagunas
Copy link
Member

Done

@brianlagunas brianlagunas modified the milestones: Prism 7.0 for XF, Prism 7.0 for WPF Jan 2, 2018
@lock
Copy link

lock bot commented Jan 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants