Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XF] Change TabbedPage deep link behavior #1187

Closed
brianlagunas opened this issue Oct 3, 2017 · 2 comments
Closed

[XF] Change TabbedPage deep link behavior #1187

brianlagunas opened this issue Oct 3, 2017 · 2 comments
Labels

Comments

@brianlagunas
Copy link
Member

brianlagunas commented Oct 3, 2017

I am thinking of introducing a major behavior breaking change when it comes to TabbedPages and deep linking.

Currently if you had the following link NavigateAsync("TabbedPage/SomeView") if "SomeView" was a tab, it would be selected and then navigation would continue. I am proposing to change this behavior to add a paremeter to indicate which tab you would like to select instead.

NavigateAsync("TabbedPage?selectedTab=SomeView")

In this case, the selected tab would be made using the parameter, and the SomeView would be created and added to the navigation stack using the standard deep link logic.

My only thought is how would we control nested navigation where your tab is a NavigationPage and you want to navigate in that tab only.

Currently done with: NavigateAsync("TabbedPage/NavigationPage/SomeView/SomeOtherView")

This would navigate to the tabbed page, selected the first NavigationPage it found, and then push the SomeOtherVew onto the stack.

I'm not sure I have an answer for that behavior at the moment.

This would also help address the issue of #650 and passing parameters to all tabs.

Thoughts?

@brianlagunas
Copy link
Member Author

fixed with PR #1195

@brianlagunas brianlagunas added this to the Prism 7.0 milestone Oct 5, 2017
@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant