Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IApplicationLifecycle to IApplicationLifecycleAware #1198

Closed
mgj opened this issue Oct 6, 2017 · 5 comments
Closed

Rename IApplicationLifecycle to IApplicationLifecycleAware #1198

mgj opened this issue Oct 6, 2017 · 5 comments
Labels

Comments

@mgj
Copy link
Contributor

mgj commented Oct 6, 2017

I would very much like to rename IApplicationLifecycle to IApplicationLifecycleAware in an attempt to:

  1. Make it more discoverable
  2. Make it consistent with the naming of INavigationAware

Implementing IApplicationLifecycle does not actually create a lifecycle, as the current name may suggest, it only lets you be aware of the current lifecycle. Please let me know what you think

Package info

  • Platform: All
  • Prism version: 6.3.0
@brianlagunas
Copy link
Member

Well, it doesn't make it more discoverable, but it does align better with our current naming convention. Since it's not documented and has a very low usage, I think we can make this change. I am wondering if we should also add OnStartup to it as well?

@brianlagunas
Copy link
Member

Nah, let's leave OnStartup off.

@mgj
Copy link
Contributor Author

mgj commented Oct 6, 2017

I can definitely see some apps wanting to use OnStartup but honestly, after dealing with the insanity that is android activity and fragment lifecycle callbacks, im leaning towards keeping the lifecycle as simple as possible

@brianlagunas
Copy link
Member

Done

@lock
Copy link

lock bot commented Jan 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants