Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INavigationAware methods are not called on children of a CarouselPage #1354

Closed
fms10 opened this issue Jan 31, 2018 · 5 comments
Closed

INavigationAware methods are not called on children of a CarouselPage #1354

fms10 opened this issue Jan 31, 2018 · 5 comments
Labels

Comments

@fms10
Copy link

fms10 commented Jan 31, 2018

Description

The methods OnNavigatingTo, OnNavigatedTo and OnNavigatedFrom of the Prism.Forms PageNavigationService do not call the corresponding INavigationAware method on the current child of a CarouselPage. This is only implemented for TabbedPages so far.

Basic Information

  • Version with issue: 7.0.0.396
  • Last known good version: 6.3.0
  • Xamarin.Forms version: 2.5.0.122203
  • IDE: VS2017
@fms10 fms10 changed the title INavigatingAware methods are not called on children of a CarouselPage INavigationAware methods are not called on children of a CarouselPage Jan 31, 2018
@brianlagunas
Copy link
Member

Are you expecting these methods to fire when you change pages within the CarouselPage? Or, are these not firing when navigating away from the CarouselPage to another Page in the navigation stack?

Also, I thought CarouselPage is a dead page and Xamarin was working on a CarouselView instead :)

@fms10
Copy link
Author

fms10 commented Jan 31, 2018

I'm expecting these methods to fire on the child page at least when navigating to a CarouselPage with an Uri like, e.g. "/LoginContainer?selectedTab=Login" where "LoginContainer" is a CarouselPage and "Login" is a ContentPage within the CarouselPage. With version 7, the methods are called on the LoginContainer but not on the Login page.

There is a lot of code in Prism.Forms' navigation service to handle CarouselPages. I therefore got the impression, that CarouselPages are explicitly supported, even if they might be obsoleted eventually.

@brianlagunas
Copy link
Member

Thanks for the clarification. Should be an easy fix.

I don't see many people using the CarouselPage, so I was just curious :)

@brianlagunas
Copy link
Member

fixed

@lock
Copy link

lock bot commented Jan 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants