-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INavigationAware methods are not called on children of a CarouselPage #1354
Comments
Are you expecting these methods to fire when you change pages within the CarouselPage? Or, are these not firing when navigating away from the CarouselPage to another Page in the navigation stack? Also, I thought CarouselPage is a dead page and Xamarin was working on a CarouselView instead :) |
I'm expecting these methods to fire on the child page at least when navigating to a CarouselPage with an Uri like, e.g. "/LoginContainer?selectedTab=Login" where "LoginContainer" is a CarouselPage and "Login" is a ContentPage within the CarouselPage. With version 7, the methods are called on the LoginContainer but not on the Login page. There is a lot of code in Prism.Forms' navigation service to handle CarouselPages. I therefore got the impression, that CarouselPages are explicitly supported, even if they might be obsoleted eventually. |
Thanks for the clarification. Should be an easy fix. I don't see many people using the CarouselPage, so I was just curious :) |
fixed |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
The methods OnNavigatingTo, OnNavigatedTo and OnNavigatedFrom of the Prism.Forms PageNavigationService do not call the corresponding INavigationAware method on the current child of a CarouselPage. This is only implemented for TabbedPages so far.
Basic Information
The text was updated successfully, but these errors were encountered: