things to check before prod

[u9g]

• air is not diggable
• grass_block and dirt have effective tools
• dont add repairWith if it's empty

[u9g]

eventually would be nice to add cake food/sat to foods.json

[u9g]

• 1.15's lootContextBuilder should add .put(LootContextParameters.BLOCK_STATE, blockState) ...etc

[u9g]

• so many versions have maxDurability wrong, it should be item#getMaxDamage

[u9g]

• round depth to 2 decimals, or just like all numbers

Use BigDecimal in food data generator

[u9g]

• remove the currentEnvironment == EnvType.CLIENT from every version:

if (currentEnvironment == EnvType.CLIENT) {
    constantTintColors = generateConstantTintColors();
}

[u9g]

• rename ClientSideAnnoyances to be lowercase

[u9g]

• most versions dont need MiningToolAccessor, there is a item.getEffectiveBlocks()...

[u9g]

• add attributes.json to all versions (1.16+, resources have minecraft: prefix)

[u9g]

• enchantment.isDifferent in EnchantmentsDataGenerator should have a not before it, ie:

            if (!enchantment.isDifferent(other) && other != enchantment) {

[u9g]

• make sure getMaximumPower is properly used on all enchants, since it is overridden

-        int b = getMaximumPower(enchantment,0);
-        int a = getMaximumPower(enchantment,1) - b;
+        int b = enchantment.getMaximumPower(0);
+        int a = enchantment.getMaximumPower(1) - b;

[u9g]

• update SkyColors from 1.11.2

[u9g]

• remove stackSize from blocks.json in all versions

[u9g]

• remove this comment

        // FIXME: ENTITY ID IS WRONG

[u9g]

• vanishable should not be in the enchantCategories for all items in items.json...

[u9g]

• make sure BlockDataDumper's emitLight is correct for all versions

[u9g]

• replace DGU.getCurrentlyRunningServer().stopServer(); with System.exit(0) everywhere

[rom1504]

@AlexProgrammerDE any thoughts on those ?