Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle data. #405

Closed
Zn10plays opened this issue May 19, 2021 · 9 comments
Closed

Add particle data. #405

Zn10plays opened this issue May 19, 2021 · 9 comments

Comments

@Zn10plays
Copy link

Add particle data to McData. For example name, states, and other info

@nickelpro
Copy link
Member

nickelpro commented May 19, 2021

Particle names and IDs are already a part of particles.json. This information could be potentially expanded, what's there now is just what's useful for the protocol. The relevant burger topping is particletypes.py if someone wanted to automate it. Although it's worth mentioning that IIRC the particle types classes actually have very little information in them besides name and ID.

EDIT: Derp, meant "not much more"

@u9g
Copy link
Member

u9g commented May 19, 2021

Particle names and IDs are already a part of particles.json. This information could be potentially expanded, what's there now is just what's useful for the protocol. The relevant burger topping is particletypes.py if someone wanted to automate it. Although it's worth mentioning that IIRC the particle types classes actually have much more information in them than name and ID.

Unless I’m missing something, the topping seems to not work for 1.16.5

@nickelpro
Copy link
Member

Haven't tested it at all, I'll take a look at it now. Likely a class moved, shouldn't be a rough fix

@nickelpro
Copy link
Member

Nope, works fine for me

$ python munch.py --download=1.16.5 --toppings=particletypes
[
    {
        "classes": {
            "anvilchunkloader": "zs",
            "biome.list": "kp",
            "biome.register": "kp",
            "block.list": "bup",
            "block.register": "bup",
            "blockstate": "ceh",
            "blockstatecontainer": "cei$a",
            "chatcomponent": "nr",
            "entity.list": "aqe",
            "enumfacing.plane": "gc$c",
            "identifier": "vk",
            "item.list": "bmd",
            "item.register": "bmd",
            "itemstack": "bmb",
            "metadata": "uv",
            "nbtcompound": "md",
            "nethandler.client": "dwu",
            "nethandler.server": "aaz",
            "packet.connectionstate": "ne",
            "packet.packetbuffer": "nf",
            "particle": "hf",
            "particletypes": "hh",
            "recipe.superclass": "jg",
            "sounds.event": "adq",
            "sounds.list": "adq",
            "tileentity.superclass": "ccj"
        },
        "particletypes": [
            "ambient_entity_effect",
            "angry_villager",
            "barrier",
            "block",
            "bubble",
            "cloud",
            "crit",
            "damage_indicator",
            "dragon_breath",
            "dripping_lava",
            "falling_lava",
            "landing_lava",
            "dripping_water",
            "falling_water",
            "dust",
            "effect",
            "elder_guardian",
            "enchanted_hit",
            "enchant",
            "end_rod",
            "entity_effect",
            "explosion_emitter",
            "explosion",
            "falling_dust",
            "firework",
            "fishing",
            "flame",
            "soul_fire_flame",
            "soul",
            "flash",
            "happy_villager",
            "composter",
            "heart",
            "instant_effect",
            "item",
            "item_slime",
            "item_snowball",
            "large_smoke",
            "lava",
            "mycelium",
            "note",
            "poof",
            "portal",
            "rain",
            "smoke",
            "sneeze",
            "spit",
            "squid_ink",
            "sweep_attack",
            "totem_of_undying",
            "underwater",
            "splash",
            "witch",
            "bubble_pop",
            "current_down",
            "bubble_column_up",
            "nautilus",
            "dolphin",
            "campfire_cosy_smoke",
            "campfire_signal_smoke",
            "dripping_honey",
            "falling_honey",
            "landing_honey",
            "falling_nectar",
            "ash",
            "crimson_spore",
            "warped_spore",
            "dripping_obsidian_tear",
            "falling_obsidian_tear",
            "landing_obsidian_tear",
            "reverse_portal",
            "white_ash"
        ],
        "source": {
            "classes": 5445,
            "file": "1.16.5.jar",
            "other": 14646,
            "size": 17547153
        }
    }
]

@u9g
Copy link
Member

u9g commented May 19, 2021

in

Nope, works fine for me

$ python munch.py --download=1.16.5 --toppings=particletypes
[
    {
        "classes": {
            "anvilchunkloader": "zs",
            "biome.list": "kp",
            "biome.register": "kp",
            "block.list": "bup",
            "block.register": "bup",
            "blockstate": "ceh",
            "blockstatecontainer": "cei$a",
            "chatcomponent": "nr",
            "entity.list": "aqe",
            "enumfacing.plane": "gc$c",
            "identifier": "vk",
            "item.list": "bmd",
            "item.register": "bmd",
            "itemstack": "bmb",
            "metadata": "uv",
            "nbtcompound": "md",
            "nethandler.client": "dwu",
            "nethandler.server": "aaz",
            "packet.connectionstate": "ne",
            "packet.packetbuffer": "nf",
            "particle": "hf",
            "particletypes": "hh",
            "recipe.superclass": "jg",
            "sounds.event": "adq",
            "sounds.list": "adq",
            "tileentity.superclass": "ccj"
        },
        "particletypes": [
            "ambient_entity_effect",
            "angry_villager",
            "barrier",
            "block",
            "bubble",
            "cloud",
            "crit",
            "damage_indicator",
            "dragon_breath",
            "dripping_lava",
            "falling_lava",
            "landing_lava",
            "dripping_water",
            "falling_water",
            "dust",
            "effect",
            "elder_guardian",
            "enchanted_hit",
            "enchant",
            "end_rod",
            "entity_effect",
            "explosion_emitter",
            "explosion",
            "falling_dust",
            "firework",
            "fishing",
            "flame",
            "soul_fire_flame",
            "soul",
            "flash",
            "happy_villager",
            "composter",
            "heart",
            "instant_effect",
            "item",
            "item_slime",
            "item_snowball",
            "large_smoke",
            "lava",
            "mycelium",
            "note",
            "poof",
            "portal",
            "rain",
            "smoke",
            "sneeze",
            "spit",
            "squid_ink",
            "sweep_attack",
            "totem_of_undying",
            "underwater",
            "splash",
            "witch",
            "bubble_pop",
            "current_down",
            "bubble_column_up",
            "nautilus",
            "dolphin",
            "campfire_cosy_smoke",
            "campfire_signal_smoke",
            "dripping_honey",
            "falling_honey",
            "landing_honey",
            "falling_nectar",
            "ash",
            "crimson_spore",
            "warped_spore",
            "dripping_obsidian_tear",
            "falling_obsidian_tear",
            "landing_obsidian_tear",
            "reverse_portal",
            "white_ash"
        ],
        "source": {
            "classes": 5445,
            "file": "1.16.5.jar",
            "other": 14646,
            "size": 17547153
        }
    }
]

nvm, i meant that we dont have a module for burgerextractor for particles to make the particles.json iirc

@nickelpro
Copy link
Member

Ya that's because I have no idea how to write javascript. It's a dead simple transformation though, the index of the name in the particletypes list is the particle ID. Someone who knows JS could write an extractor in a second.

@u9g
Copy link
Member

u9g commented May 19, 2021

Ya that's because I have no idea how to write javascript. It's a dead simple transformation though, the index of the name in the particletypes list is the particle ID. Someone who knows JS could write an extractor in a second.

ah you were right, made PrismarineJS/burger-extractor#15

@nickelpro
Copy link
Member

Fairly certain this can be closed unless I'm missing something

@nickelpro
Copy link
Member

Closing this for now. I'm unaware of any particle data that isn't covered between particles.json and protocol.json. If there's something that we're missing it can be worked on in a bug report that lays out specifically what's needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants