Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minStateId, maxStateId and defaultState to legacy versions of blocks.json #428

Closed
IceTank opened this issue Jul 10, 2021 · 2 comments
Closed

Comments

@IceTank
Copy link
Contributor

IceTank commented Jul 10, 2021

Block instance for versions <1.13 do not contain minStateId, maxStateId and defaultState. The states are needed in cross version compatibility.

@rom1504
Copy link
Member

rom1504 commented Jul 10, 2021

not convinced, there is no state in <1.13
shouldn't this be handled in prismarine-block ?

@nickelpro
Copy link
Member

Blocks don't have states pre-flattening, they have variations. MCD is not the place to hide the complexity of the pre/post flattening switch, just like we don't attempt to hide pre/post netty, or large differences in packet structure.

@rom1504 rom1504 closed this as completed Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants