Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoalGetToBlock isEnd treats being at destination exactly as being adjacent #114

Closed
Slord6 opened this issue Jan 27, 2021 · 3 comments
Closed

Comments

@Slord6
Copy link
Contributor

Slord6 commented Jan 27, 2021

The description of GoalGetToBlock says "Don't get into the block, but get directly adjacent to it.". However, if the Mineflayer agent's goal is an air block that it is already stood in, then it treats the goal as reached. This is an issue if the bot needs to place a block at that position as that is not possible when the agent is stood in place.

Relevant code link:

isEnd (node) {

Is it possible to aim specifically for adjacent blocks currently?

Edit: Possibly relates to (closed) PR #23 and Issue #38

@Karang
Copy link
Collaborator

Karang commented Jan 27, 2021

Yes, good point, should add a check for node != this in the isEnd function

@Karang Karang closed this as completed in d45b5bb Jan 27, 2021
@Karang
Copy link
Collaborator

Karang commented Jan 27, 2021

Done

@Slord6
Copy link
Contributor Author

Slord6 commented Jan 27, 2021

Great! Thankyou :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants