Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promisify #89

Closed
TheDudeFromCI opened this issue Dec 18, 2020 · 3 comments
Closed

Promisify #89

TheDudeFromCI opened this issue Dec 18, 2020 · 3 comments

Comments

@TheDudeFromCI
Copy link
Member

Given that the Mineflayer codebase is now using Promises instead of callbacks, it would make sense for all official Mineflayer plugins to also move in that direction.

@Karang
Copy link
Collaborator

Karang commented Dec 18, 2020

Sure. As far as the api is concerned, there will be very little change as most of it is sync anyway. But it makes sense to use the promise versions of the calls to mineflayer's api.

@TheDudeFromCI
Copy link
Member Author

Yeah, it's mostly just a matter of consistency more than anything. It's 95% of the way there already.

@u9g
Copy link
Member

u9g commented Feb 21, 2021

done, pls close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants